feat: changelog filters are specialized per vcs type #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codejedi365
changed the title
codejedi365
force-pushed
the
feat/changelog-filters-hvcs-specialized
branch
2 times, most recently
from
920b1e2
to
48db060
Compare
…n remote base class
codejedi365
force-pushed
the
feat/changelog-filters-hvcs-specialized
branch
from
48db060
to
9ca8563
Compare
codejedi365
force-pushed
the
feat/changelog-filters-hvcs-specialized
branch
from
a75ee61
to
7ad7d65
Compare
codejedi365
force-pushed
the
feat/changelog-filters-hvcs-specialized
branch
from
7ad7d65
to
2e4c747
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Refactor changelog context to gather filters from the features available in the HVCS
Resolve: #671
Rationale
This allows for more specialization long term regardless of functions that are not common across all VCS's. This also includes a refactoring of the base classes to divide up functionality that is can deviate when certain functions are unavailable for a specific HVCS.
How I tested
Created tests that evaluate each filter function of a carefully crafted changelog template that purposefully exercises each HVCS's changelog filters.