feat: extend support to on-prem GitHub Enterprise Server #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codejedi365
force-pushed
the
feat/add-github-on-prem-support
branch
2 times, most recently
from
f2e6e57
to
8cb7847
Compare
codejedi365
force-pushed
the
feat/add-github-on-prem-support
branch
from
8cb7847
to
1a5840e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Extend support to handle GitHub Enterprise Server for on-premise usage with a non sub-domain api url
Resolve #895
Rationale
This PR adds logic to derive the api domains based on which product is used. It is assumed that GitHub Enterprise Cloud is using
github.comwhich uses a subdomain for api requests. This assumption may be wrong but it is the best we have today. When it is notgithub.com, then we assume that GitHub Enterprise Server product is being used as it is hosted on-prem by the organization that owns the domain. If on-prem is detected, than it is assumed that the api location is a subpath of the base domain.How I tested
There are some unit tests to ensure the derivative and detection mechanisms work but ultimately the author of #895 tested it in their environment and confirmed that it successfully made a release on their internal server.