fix(gha): add missing tag option to GitHub Action definition
#908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rantoniuk
reviewed
May 3, 2024
codejedi365
force-pushed
the
fix/gha-missing-tag-option
branch
2 times, most recently
from
96f26e5
to
54e765a
Compare
codejedi365
force-pushed
the
fix/gha-missing-tag-option
branch
from
54e765a
to
f4276a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
--tagcommand line option added inv8.4.0Rationale
First I must add the definition to the
action.ymlfile to ensure that users can provide atagdirective to theirGitHub Actiondefinition. This then translates to a new environment variable that is passed to theaction.sh. That variable must be read in order to determine if it should add a true or false command line option to thesemantic-release versioncommand. Lastly, I decided to remove all the extra default values from theaction.*files because they we are maintaining multiple locations where the defaults are set for the project.