Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA of PSR 9.7.0 does not respect git_committer_name and git_committer_email anymore #918

Closed
afuetterer opened this issue May 6, 2024 · 3 comments · Fixed by #919
Closed
Assignees
Labels
bug Something isn't working properly

Comments

@afuetterer
Copy link
Contributor

afuetterer commented May 6, 2024

The problem

I used the GHA of PSR 9.6.0 with git_committer_name and git_committer_email configured to let the release commit be from the GitHub bot with its avatar icon. Updating to PSR 9.7.0 now I get commits made by semantic-release <semantic-release>. Do I need to change something or is this a bug in 9.7.0?

Expected behavior

I expected the committer to still be github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>.

Environment

Do you need this information, if I have a problem using the GHA?
See: https://github.com/afuetterer/services-test4

Please state which OS you are using and provide the output of the following commands:

python --version
pip --version
semantic-release --version
pip freeze

Please also indicate which Python build tool(s) you are using (e.g. pip, build,
poetry, etc.), including the version number too.

Configuration

[tool.semantic_release]
commit_message = "chore: release {version}\n\nAutomatically generated by python-semantic-release [skip ci]"
logging_use_named_masks = true
major_on_zero = false
tag_format = "{version}"
version_toml = ["pyproject.toml:project.version"]
build_command = """
sed -i "s/^version: .*/version: $NEW_VERSION/" CITATION.cff
sed -i "s/^date-released: .*/date-released: $(date "+%Y-%m-%d")/" CITATION.cff
git add CITATION.cff
python -m pip install "build[uv]>=1.2.1"
python -m build --installer=uv
"""
changelog.template_dir = ".github/templates"

[tool.semantic_release.changelog.environment]
keep_trailing_newline = true
  - name: Create semantic release
    id: semantic-release
    uses: python-semantic-release/python-semantic-release@76b17cc32ac75b87ae301df6d302f71c5eefa9b3 # v9.7.0
    with:
      github_token: ${{ secrets.SEMANTIC_RELEASE_TOKEN }}
      git_committer_name: github-actions[bot]
      git_committer_email: 41898282+github-actions[bot]@users.noreply.github.com
      root_options: -vv

Logs

See: https://github.com/afuetterer/services-test4/actions/runs/8966931525/job/24623457653

Note: This is only a dummy project to test things out.

Additional context

Example commits from before and after updating to 9.7.0:

commit 43d08d648a44cd6e2d0d376fff911b0fc535580c (HEAD -> main, tag: 0.19.3, origin/main)
Author: semantic-release <semantic-release>
Date:   Mon May 6 09:27:30 2024 +0000

    chore: release 0.19.3
    
    Automatically generated by python-semantic-release [skip ci]

# update to PSR 9.7.0 ...

commit f2c05e6db68f83a3c1add6265634837368e955eb (tag: 0.18.0)
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Mon May 6 08:49:57 2024 +0000

    chore: release 0.18.0
    
    Automatically generated by python-semantic-release [skip ci]
@afuetterer afuetterer added the bug Something isn't working properly label May 6, 2024
@codejedi365
Copy link
Contributor

codejedi365 commented May 6, 2024

I'm thinking this is a bug I introduced by accident during my refactor. Thanks for the notification.

You can set it in the configuration file if you want to but obviously any local release would also use the configured value.

@afuetterer
Copy link
Contributor Author

afuetterer commented May 6, 2024

I thought so. I did not touch my configuration, and it stopped working the way it used to from 9.6 to 9.7.

You updated the "get git details" in action.sh. Could that be it?

@afuetterer afuetterer changed the title GHA of PRS 9.7.0 does not use git_committer_name and git_committer_email anymore? GHA of PRS 9.7.0 does not respect git_committer_name and git_committer_email anymore May 6, 2024
codejedi365 added a commit to codejedi365/python-semantic-release that referenced this issue May 7, 2024
codejedi365 added a commit to codejedi365/python-semantic-release that referenced this issue May 7, 2024
codejedi365 added a commit to codejedi365/python-semantic-release that referenced this issue May 7, 2024
@codejedi365 codejedi365 self-assigned this May 7, 2024
@codejedi365
Copy link
Contributor

🎉 This issue has been resolved in version 9.7.1 🎉

The release is available on:

@codejedi365 codejedi365 changed the title GHA of PRS 9.7.0 does not respect git_committer_name and git_committer_email anymore GHA of PSR 9.7.0 does not respect git_committer_name and git_committer_email anymore May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working properly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants