Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update dependencies to latest #128

Closed
wants to merge 1 commit into from

Conversation

chantastic
Copy link

Hi, I'm updating to Astro v4. It uses unified v11 and I'm having trouble using this package.

I attempted a personal fork. But that introduced environment overhead that I wasn't ready to accept. lol.

In any case, this PR updates all of the dependencies to latest. I ran test and build it passed both. Feel free to disregard this for a new branch and PR. It's mostly intended as confirmation that the update appears simple enough.

CleanShot 2024-01-24 at 06 30 15@2x

chantastic added a commit to chantastic/sites that referenced this pull request Jan 24, 2024
- https://docs.astro.build/en/guides/upgrade-to/v4/
- remark-embedder/core#128
- https://pnpm.io/cli/add
- https://github.com/changesets/changesets
- https://github.com/changesets/changesets/blob/main/docs/intro-to-using-changesets.md
- https://oembed.com/
- https://oembed.com/providers.json
- remark-embedder/core#128

Error:

```
ZodError: [
  {
    "code": "invalid_union",
    "unionErrors": [
      {
        "issues": [
          {
            "code": "invalid_type",
            "expected": "string",
            "received": "array",
            "path": [
              "markdown",
              "remarkPlugins",
              7
            ],
            "message": "Expected string, received array"
          }
        ],
        "name": "ZodError"
      },
      {
        "issues": [
          {
            "code": "invalid_type",
            "expected": "string",
            "received": "object",
            "path": [
              "markdown",
              "remarkPlugins",
              7,
              0
            ],
            "message": "Expected string, received object"
          }
        ],
        "name": "ZodError"
      },
      {
        "issues": [
          {
            "code": "custom",
            "fatal": true,
            "path": [
              "markdown",
              "remarkPlugins",
              7
            ],
            "message": "Invalid input"
          }
        ],
        "name": "ZodError"
      },
      {
        "issues": [
          {
            "code": "custom",
            "fatal": true,
            "path": [
              "markdown",
              "remarkPlugins",
              7,
              0
            ],
            "message": "Invalid input"
          }
        ],
        "name": "ZodError"
      }
    ],
    "path": [
      "markdown",
      "remarkPlugins",
      7
    ],
    "message": "Invalid input"
  }
]
    at get error [as error] (file:///Users/chan/sites/chan.dev/node_modules/.pnpm/zod@3.22.4/node_modules/zod/lib/index.mjs:538:31)
    at ZodEffects.parseAsync (file:///Users/chan/sites/chan.dev/node_modules/.pnpm/zod@3.22.4/node_modules/zod/lib/index.mjs:661:22)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async validateConfig (file:///Users/chan/sites/chan.dev/node_modules/.pnpm/astro@4.2.4/node_modules/astro/dist/core/config/config.js:17:14)
    at async resolveConfig (file:///Users/chan/sites/chan.dev/node_modules/.pnpm/astro@4.2.4/node_modules/astro/dist/core/config/config.js:120:23)
    at async restartContainer (file:///Users/chan/sites/chan.dev/node_modules/.pnpm/astro@4.2.4/node_modules/astro/dist/core/dev/restart.js:45:29)
    at async handleServerRestart (file:///Users/chan/sites/chan.dev/node_modules/.pnpm/astro@4.2.4/node_modules/astro/dist/core/dev/restart.js:91:20)
```
@MichaelDeBoey MichaelDeBoey linked an issue Jan 26, 2024 that may be closed by this pull request
Copy link
Member

@MichaelDeBoey MichaelDeBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chantastic Can you please also update the Validate workflow to exclude Node v14 and update package.json as well?


BREAKING CHANGE: Requires Node@>=16

@MichaelDeBoey MichaelDeBoey changed the title Update dependencies to latest feat: update dependencies to latest Jan 26, 2024
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds
Copy link
Member

Bummer. Looks like there's something wrong with the validate script on CI and I'm afraid I don't have the bandwidth to figure it out right now :(

kentcdodds added a commit that referenced this pull request May 22, 2024
Closes #128
Closes #127

BREAKING CHANGES: Drop support for Node <= 18 and bump all unified deps
Copy link

🎉 This issue has been resolved in version 3.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plans to update unified dependencies?
3 participants