Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can this work client-side? #2

Closed
TiborUdvari opened this issue Apr 12, 2021 · 4 comments
Closed

Can this work client-side? #2

TiborUdvari opened this issue Apr 12, 2021 · 4 comments
Labels

Comments

@TiborUdvari
Copy link

Is this intended to be able to work client side with components such as react-markdown?
https://github.com/remarkjs/react-markdown

I'm trying to use it in a preview component for a blog writing component.

I'm getting this module dependency error, although, again, I'm not sure if it's intended to work as I'm expecting.

Module not found: Can't resolve 'dns'
@kentcdodds
Copy link
Member

Oh, interesting. I hadn't thought about supporting the client side. I think what we need to do is dynamically import the make-fetch-happen and the url module if fetch/URL aren't already defined. Would you be willing to make that work?

@NyakoFox
Copy link

NyakoFox commented Oct 9, 2023

Has there been any progress on this?

@kentcdodds
Copy link
Member

Nobody's working on it

Copy link

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants