Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to TS 5 #734

Merged
merged 1 commit into from Mar 20, 2023
Merged

Update to TS 5 #734

merged 1 commit into from Mar 20, 2023

Conversation

Methuselah96
Copy link
Contributor

@Methuselah96 Methuselah96 commented Mar 20, 2023

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Fixes a type error that is new in TypeScript 5.0:

ERROR in node_modules/react-markdown/lib/ast-to-react.d.ts:17:44
TS2344: Type 'T' does not satisfy the constraint 'ElementType<any>'.
  Type 'T' is not assignable to type 'FunctionComponent<any>'.
    15 |  */
    16 | export type ComponentPropsWithoutRef<T> =
  > 17 |   import('react').ComponentPropsWithoutRef<T>
       |                                            ^
    18 | export type ReactNode = import('react').ReactNode
    19 | export type Position = import('unist').Position
    20 | export type Element = import('hast').Element

@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Mar 20, 2023
@github-actions

This comment has been minimized.

@github-actions github-actions bot added 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Mar 20, 2023
@wooorm wooorm changed the title Fix new type error in TypeScript 5.0 Update to TS 5 Mar 20, 2023
@wooorm wooorm merged commit 33ab015 into remarkjs:main Mar 20, 2023
5 checks passed
@wooorm wooorm added ☂️ area/types This affects typings 💪 phase/solved Post is done labels Mar 20, 2023
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Mar 20, 2023
@Methuselah96 Methuselah96 deleted the fix-typescript.5.0 branch March 20, 2023 12:40
@wooorm
Copy link
Member

wooorm commented Mar 20, 2023

Thanks, released in 8.0.6!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants