Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request cutting out a new release #1162

Closed
4 tasks done
OmarTawfik opened this issue May 16, 2023 · 2 comments
Closed
4 tasks done

Request cutting out a new release #1162

OmarTawfik opened this issue May 16, 2023 · 2 comments
Labels
💪 phase/solved Post is done

Comments

@OmarTawfik
Copy link

Initial checklist

Problem

Following up on syntax-tree/mdast-util-from-markdown#32 .. cc @wooorm

The problem is that remark-parse was last published (2 years ago) before "moduleResolution": "node16" was a thing (it’s not even in remark yet: https://github.com/remarkjs/remark/blob/main/tsconfig.json). 2 years ago, the TS CLI generated code that doesn’t work in todays TS with moduleResolution: node16.

I believe that the solution is to use a current correct TS config (e.g., like this: https://github.com/syntax-tree/mdast-util-from-markdown/blob/cd10e598ae2492c8b61131d2ace46e0ea7cc37e5/tsconfig.json), then regenerate all types in remark, and cut a new release

I checked remark-parse, and it looks like it is already extending the root tsconfig.json, which was up to date .

I tried rebuilding the package locally, and the type error is no longer reported:

node_modules/remark-parse/lib/index.d.ts:3:26 - error TS2307: Cannot find module 'mdast-util-from-markdown/lib' or its corresponding type declarations.

3   options: void | import('mdast-util-from-markdown/lib').Options | undefined

Found 1 error in node_modules/remark-parse/lib/index.d.ts:3

Solution

It looks like all what we need is cutting out a new release should fix this.

Please let me know if there is anything else I can do.

Alternatives

N/A

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels May 16, 2023
@wooorm
Copy link
Member

wooorm commented May 16, 2023

Done, thanks! https://github.com/remarkjs/remark/releases/tag/14.0.3

@wooorm wooorm added the 💪 phase/solved Post is done label May 16, 2023
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label May 16, 2023
@wooorm wooorm closed this as completed May 16, 2023
@OmarTawfik
Copy link
Author

Thank you!

tylersmalley pushed a commit to tailscale-dev/tailscale-dev that referenced this issue Jun 5, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [remark](https://remark.js.org)
([source](https://togithub.com/remarkjs/remark)) | [`^14.0.2` ->
`^14.0.3`](https://renovatebot.com/diffs/npm/remark/14.0.2/14.0.3) |
[![age](https://badges.renovateapi.com/packages/npm/remark/14.0.3/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/remark/14.0.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/remark/14.0.3/compatibility-slim/14.0.2)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/remark/14.0.3/confidence-slim/14.0.2)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>remarkjs/remark</summary>

###
[`v14.0.3`](https://togithub.com/remarkjs/remark/releases/tag/14.0.3)

[Compare
Source](https://togithub.com/remarkjs/remark/compare/14.0.2...14.0.3)

##### Misc

-   Rerelease types for changes in TypeScript

[remarkjs/remark#1162
- [`f6bd64e`](https://togithub.com/remarkjs/remark/commit/f6bd64e6)
Refactor `tsconfig`s for perf and strictness
- [`bb4c814`](https://togithub.com/remarkjs/remark/commit/bb4c8143) Add
improved docs on what this project is
by [@&#8203;BeLi4L](https://togithub.com/BeLi4L) in
[remarkjs/remark#1147
- [`bec44aa`](https://togithub.com/remarkjs/remark/commit/bec44aa0)
Update `tsconfig.json` to use node16 module resolution
by [@&#8203;ChristianMurphy](https://togithub.com/ChristianMurphy) in
[remarkjs/remark#1106
- [`f07f413`](https://togithub.com/remarkjs/remark/commit/f07f413f) Add
`ignore-scripts` to `.npmrc`
by [@&#8203;ChristianMurphy](https://togithub.com/ChristianMurphy) in
[remarkjs/remark#1103
- [`134ece2`](https://togithub.com/remarkjs/remark/commit/134ece2b)
Update Actions
by [@&#8203;ChristianMurphy](https://togithub.com/ChristianMurphy) in
[remarkjs/remark#1070
- [`974f893`](https://togithub.com/remarkjs/remark/commit/974f8936) Fix
internal types for TS 4.9

##### Plugins

- [`1e488d0`](https://togithub.com/remarkjs/remark/commit/1e488d0b) Add
`remark-ins` to list of plugins
by [@&#8203;talatkuyuk](https://togithub.com/talatkuyuk) in
[remarkjs/remark#1129
- [`e456dc5`](https://togithub.com/remarkjs/remark/commit/e456dc5b) Add
`remark-flexible-markers` to list of plugins
by [@&#8203;talatkuyuk](https://togithub.com/talatkuyuk) in
[remarkjs/remark#1126
- [`42114fc`](https://togithub.com/remarkjs/remark/commit/42114fc6) Add
`remark-flexible-paragraphs` to list of plugins
by [@&#8203;talatkuyuk](https://togithub.com/talatkuyuk) in
[remarkjs/remark#1120
- [`6aa638a`](https://togithub.com/remarkjs/remark/commit/6aa638ab) Add
`remark-flexible-containers` to list of plugins
by [@&#8203;talatkuyuk](https://togithub.com/talatkuyuk) in
[remarkjs/remark#1112
- [`20e7543`](https://togithub.com/remarkjs/remark/commit/20e75435) Add
`remark-flexible-code-titles` to list of plugins
by [@&#8203;talatkuyuk](https://togithub.com/talatkuyuk) in
[remarkjs/remark#1108
- [`32d6948`](https://togithub.com/remarkjs/remark/commit/32d69488) Add
`remark-cloudinary-docusaurus` to list of plugins
by [@&#8203;johnnyreilly](https://togithub.com/johnnyreilly) in
[remarkjs/remark#1090
- [`28aa8b9`](https://togithub.com/remarkjs/remark/commit/28aa8b9a)
update tests for changes in `mdast-util-to-markdown`
- [`9af1a87`](https://togithub.com/remarkjs/remark/commit/9af1a876) Add
`remark-code-title` to list of plugins
by [@&#8203;kevinzunigacuellar](https://togithub.com/kevinzunigacuellar)
in
[remarkjs/remark#1076
- [`0d1eb09`](https://togithub.com/remarkjs/remark/commit/0d1eb09a) Add
7 plugins to list of plugins
by [@&#8203;Xunnamius](https://togithub.com/Xunnamius) in
[remarkjs/remark#1064
- [`c7e8171`](https://togithub.com/remarkjs/remark/commit/c7e81713)
Remove deprecated `remark-jargon`
by [@&#8203;LunaticMuch](https://togithub.com/LunaticMuch) in
[remarkjs/remark#1059

**Full Changelog**:
remarkjs/remark@14.0.2...14.0.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/tailscale-dev/tailscale-dev).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS44Ny4xIiwidXBkYXRlZEluVmVyIjoiMzUuODcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 phase/solved Post is done
Development

No branches or pull requests

2 participants