Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: context binding in addModel #873

Merged
merged 1 commit into from
Mar 2, 2021
Merged

fix: context binding in addModel #873

merged 1 commit into from
Mar 2, 2021

Conversation

objectisundefined
Copy link
Contributor

for issue #872

semoal
semoal requested changes Mar 1, 2021
View reviewed changes
packages/core/test/init.test.ts Outdated
@@ -186,6 +186,23 @@ describe('init:', () => {
},
})
})

test('addModel works when it was used alone', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this test better to store.test.ts please, we already have there some tests related to storeModel =)

@semoal semoal requested a review from tianzhich March 1, 2021 14:13
@tianzhich
Copy link
Collaborator

Looks great! The bind does nothing here, change this to rematchStore would be better. Thanks for contributing @objectisundefined

@tianzhich
Copy link
Collaborator

I merged, you can publish in your free time @semoal

@tianzhich tianzhich merged commit 7f99a45 into rematch:main Mar 2, 2021
@tianzhich tianzhich linked an issue Mar 2, 2021 that may be closed by this pull request
bind here does nothing #872
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semoal semoal semoal approved these changes

@tianzhich tianzhich tianzhich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bind here does nothing
3 participants
@objectisundefined @tianzhich @semoal