Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: optional payload inference inside effects #902

Merged
merged 2 commits into from
May 25, 2021
Merged

fix: optional payload inference inside effects #902

merged 2 commits into from
May 25, 2021

Conversation

semoal
Copy link
Member

@semoal semoal commented May 25, 2021 •
edited

Related to #901

Introduces a new test to avoid regression with dispatcher system:

  • Reducers
    • With optional payload
    • With required payload
  • Effects
    • With optional payload
    • With required payload
    • With optional payload and rootState
    • With required payload and required rootstate

@semoal semoal requested a review from tianzhich May 25, 2021 09:34
@semoal semoal mentioned this pull request May 25, 2021
Merged
@github-actions
Copy link

github-actions bot commented May 25, 2021 •
edited

size-limit report 📦

Path Size
./packages/core/dist/core.umd.production.min.js 1.42 KB (0%)
./packages/immer/dist/immer.umd.production.min.js 143 B (0%)
./packages/loading/dist/loading.umd.production.min.js 596 B (0%)
./packages/persist/dist/persist.umd.production.min.js 172 B (0%)
./packages/select/dist/select.umd.production.min.js 456 B (0%)
./packages/updated/dist/updated.umd.production.min.js 407 B (0%)

tianzhich
tianzhich approved these changes May 25, 2021
View reviewed changes
Copy link
Collaborator

@tianzhich tianzhich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now all the existing tests look great. We can add more tests or merge this first and append tests in the future.

@semoal semoal merged commit 4b98af0 into fix-type-inference May 25, 2021
@semoal semoal deleted the fix-type-inference-v2 branch May 25, 2021 12:12
@semoal semoal mentioned this pull request May 25, 2021
Closed
15 tasks
tianzhich added a commit that referenced this pull request May 26, 2021
@tianzhich @semoal
fix: optional payload inference (#901)
78351ce 
* fix: optional payload inference

* fix: optional payload inference inside effects (#902)

Co-authored-by: tianzhich <zhi.tian@yahoo.com>

Co-authored-by: Sergio Moreno <sergiomorenoalbert@gmail.com>
@tianzhich tianzhich mentioned this pull request May 26, 2021
Merged
5 tasks
semoal added a commit that referenced this pull request Jun 10, 2021
@tianzhich @semoal
fix: optional payload inference (#901)
dfff163 
* fix: optional payload inference

* fix: optional payload inference inside effects (#902)

Co-authored-by: tianzhich <zhi.tian@yahoo.com>

Co-authored-by: Sergio Moreno <sergiomorenoalbert@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianzhich tianzhich tianzhich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@semoal @tianzhich