fix: reducers and effects with same name are correctly typed 4.3.X

[semoal]

Resolves #912

Before 4.3 TypeScript accepted "duplicated" types but now is more stricter, so we just merge them giving priority always to reducers because is the entrypoint (will be the first executed if the same is duplicated)

[github-actions]

size-limit report 📦

Path	Size
./packages/core/dist/core.umd.production.min.js	1.42 KB (0%)
./packages/immer/dist/immer.umd.production.min.js	143 B (0%)
./packages/loading/dist/loading.umd.production.min.js	597 B (0%)
./packages/persist/dist/persist.umd.production.min.js	172 B (0%)
./packages/select/dist/select.umd.production.min.js	456 B (0%)
./packages/updated/dist/updated.umd.production.min.js	407 B (0%)

[tianzhich]

Nice utility type. Good job mate. Do we need to add a notice about this case: if the same name used in both reducer and effects, the reducer will be executed first, and then the effects:

function createEffectsMiddleware<
	TModels extends Models<TModels>,
	TExtraModels extends Models<TModels>
>(bag: RematchBag<TModels, TExtraModels>): Middleware {
	return (store) => (next) => (action: Action): any => {
		if (action.type in bag.effects) {
			// first run reducer action if exists
			next(action)

			// then run the effect and return its result
			return (bag.effects as any)[action.type](
				action.payload,
				store.getState(),
				action.meta
			)
		}

		return next(action)
	}
}

I can't figure out this executing order until I read the above source code.

[tianzhich]

Or we should remind our users not to use this way which I think is confusing. In my opinion, we can use a more semantic name on effects if it conflicts with the reducer.

[semoal]

Or we should remind our users not to use this way which I think is confusing. In my opinion, we can use a more semantic name on effects if it conflicts with the reducer.

Technically, our recommendation is to use Uppercase for reducers and effects with camelcase in that way you can differentiate easily on Redux Devtools. But... as we accept reducers and effects with the same name, we have to accept that on typings too

[semoal]

Nice utility type. Good job mate. Do we need to add a notice about this case: if the same name used in both reducer and effects, the reducer will be executed first, and then the effects:

function createEffectsMiddleware<
	TModels extends Models<TModels>,
	TExtraModels extends Models<TModels>
>(bag: RematchBag<TModels, TExtraModels>): Middleware {
	return (store) => (next) => (action: Action): any => {
		if (action.type in bag.effects) {
			// first run reducer action if exists
			next(action)

			// then run the effect and return its result
			return (bag.effects as any)[action.type](
				action.payload,
				store.getState(),
				action.meta
			)
		}

		return next(action)
	}
}

I can't figure out this executing order until I read the above source code.

oh, i thought it was the inverse... let me check

[semoal]

@tianzhich Just introduced a new test to check the order of execution and don't introduce any regression there, also i replaced the order of the merge exclusive to give priority to reducers type.

Where the scenario of:

state: {
  count: 0,
},
reducers: {
  add(state, payload: string) {
    return state
  },
},
effects: () => ({
  add(payload: number) {
  },
}),

store.dispatch.add() will type the payload as string

[tianzhich]

well, now it's no problem for me.