Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): Tsdx is abandoned and we moved to a forked TSDX updated #939

Merged
merged 6 commits into from
Oct 11, 2021

Conversation

semoal
Copy link
Member

@semoal semoal commented Oct 4, 2021

https://github.com/weiran-zsd/dts-cli

Tsdx updated

upgrade eslint v7
upgrade typescript v4
upgrade jest v27
upgrade rollup v2
upgrade prettier v2

@semoal semoal requested a review from tianzhich October 4, 2021 18:57
@semoal
Copy link
Member Author

semoal commented Oct 4, 2021

Is still failing the examples app/, example app thinks there is a required meta but it isn't.

@tianzhich
Copy link
Collaborator

I updated the types and also tests, rebase onto the newest fix-type-inference branch. There are some errors related to jest.

@tianzhich
Copy link
Collaborator

Is still failing the examples app/, example app thinks there is a required meta but it isn't.

It happens because i fogot to update the ModelCreator overload for @rematch/select and now it was fixed.

@tianzhich
Copy link
Collaborator

I updated the types and also tests, rebase onto the newest fix-type-inference branch. There are some errors related to jest.

mate, maybe you want to git pull -f avoid the conflicts. Could you take a look on the jest errors. It seems related to the dts-cli. Run test to see them.

@semoal semoal merged commit 5769f4d into fix-type-inference Oct 11, 2021
@semoal semoal deleted the migrated-to-dts-cli branch October 11, 2021 09:01
tianzhich added a commit that referenced this pull request Oct 11, 2021
* fix(types): correct dispatcher argument inference when payload defined as any type

* fix(types): improve the inference accuracy of dispatcher

* refactor: use `RematchDispatcher` for both reducer and effect

* fix(types): remove the default effects/reducers/basereducer type if they are undefined

* test(dispatcher-typings): add more tests

* fix: use correct overload to match rematch core

* fix(): Tsdx is abandoned and we moved to a forked TSDX updated (#939)

Co-authored-by: tianzhich <zhi.tian@yahoo.com>

* docs(core): format, add new documents and revise the olds

Co-authored-by: Sergio Moreno <sergiomorenoalbert@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants