fix: circular reference destructuring works with all models

[sushantdhiman]

Fixes #811

Short version of this problem given below

/**---Problem---**/

const dispatch = {};

const gen = ({ a, b }) => {
  return {
    log: () => {
      console.log(a, b);
    }
  };
};

["a", "b"].forEach((item) => {
  const x = {};
  dispatch[item] = x;
  x['run' + item] = gen(dispatch);
});

dispatch["a"].runa.log();
dispatch["b"].runb.log();


/**--- Solution ---**/

const dispatch = {
  a: {},
  b: {}
};

const gen = ({ a, b }) => {
  return {
    log: () => {
      console.log(a, b);
    }
  };
};

["a", "b"].forEach((item) => {
  const x = dispatch[item] || {};
  dispatch[item] = x;
  x['run' + item] = gen(dispatch);
});

dispatch.a.runa.log();
dispatch.b.runb.log();

{ runa: { log: [Function: log] } } undefined
{ runa: { log: [Function: log] } } { runb: { log: [Function: log] } }

{ runa: { log: [Function: log] } } { runb: { log: [Function: log] } }
{ runa: { log: [Function: log] } } { runb: { log: [Function: log] } }

When effects method is called it can only access object references which were available to it at that time. I have separated model creation and effects creation process. Now correct models reference is available at the time of effects creation.

---

IssueHunt Summary

Referenced issues

This pull request has been submitted to:

• #811: Regression in destructuring models from effects dispatch param

---

[semoal]

LGTM, let see what Zhi Tian says

[tianzhich]

Except for one place about the function naming, all changes look great to me too.

[tianzhich]

Nice explanations here. Thanks for your contributions @sushantdhiman