-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(isDeepEqual): add support for maps #637
feat(isDeepEqual): add support for maps #637
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ddefbcf:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks for your contribution. I only have a few nits
Co-authored-by: Eran Hirsch <eranhirsch@gmail.com>
Co-authored-by: Eran Hirsch <eranhirsch@gmail.com>
Co-authored-by: Eran Hirsch <eranhirsch@gmail.com>
Co-authored-by: Eran Hirsch <eranhirsch@gmail.com>
Co-authored-by: Eran Hirsch <eranhirsch@gmail.com>
Co-authored-by: Eran Hirsch <eranhirsch@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #637 +/- ##
==========================================
+ Coverage 98.41% 98.59% +0.17%
==========================================
Files 127 154 +27
Lines 7954 10962 +3008
Branches 724 904 +180
==========================================
+ Hits 7828 10808 +2980
- Misses 123 151 +28
Partials 3 3 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Eran Hirsch <eranhirsch@gmail.com>
🎉 This PR is included in version 1.59.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Add support for maps for the isDeepEqual function
Fixes: #626