Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isDeepEqual): add support for maps #637

Merged

Conversation

clemgbld
Copy link
Contributor

@clemgbld clemgbld commented Apr 13, 2024

Add support for maps for the isDeepEqual function

Fixes: #626

@clemgbld clemgbld changed the title feat(isDeepEqual): add support for maps #626 feat(isDeepEqual): add support for maps Apr 13, 2024
Copy link

codesandbox-ci bot commented Apr 13, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ddefbcf:

Sandbox Source
remeda-example-vanilla Configuration

src/isDeepEqual.test.ts Show resolved Hide resolved
src/isDeepEqual.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@eranhirsch eranhirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for your contribution. I only have a few nits

src/isDeepEqual.ts Outdated Show resolved Hide resolved
src/isDeepEqual.ts Outdated Show resolved Hide resolved
src/isDeepEqual.ts Outdated Show resolved Hide resolved
src/isDeepEqual.test.ts Show resolved Hide resolved
src/isDeepEqual.test.ts Show resolved Hide resolved
clemgbld and others added 6 commits April 14, 2024 12:13
Co-authored-by: Eran Hirsch <eranhirsch@gmail.com>
Co-authored-by: Eran Hirsch <eranhirsch@gmail.com>
src/isDeepEqual.ts Outdated Show resolved Hide resolved
src/isDeepEqual.test.ts Show resolved Hide resolved
src/isDeepEqual.test.ts Show resolved Hide resolved
src/isDeepEqual.test.ts Show resolved Hide resolved
clemgbld and others added 7 commits April 14, 2024 12:38
Co-authored-by: Eran Hirsch <eranhirsch@gmail.com>
Co-authored-by: Eran Hirsch <eranhirsch@gmail.com>
Co-authored-by: Eran Hirsch <eranhirsch@gmail.com>
Co-authored-by: Eran Hirsch <eranhirsch@gmail.com>
Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.59%. Comparing base (96a4e82) to head (ddefbcf).
Report is 86 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #637      +/-   ##
==========================================
+ Coverage   98.41%   98.59%   +0.17%     
==========================================
  Files         127      154      +27     
  Lines        7954    10962    +3008     
  Branches      724      904     +180     
==========================================
+ Hits         7828    10808    +2980     
- Misses        123      151      +28     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/isDeepEqual.ts Outdated Show resolved Hide resolved
clemgbld and others added 3 commits April 14, 2024 13:47
Co-authored-by: Eran Hirsch <eranhirsch@gmail.com>
@eranhirsch eranhirsch merged commit c5e47a5 into remeda:master Apr 14, 2024
22 checks passed
@TkDodo
Copy link
Collaborator

TkDodo commented Apr 14, 2024

🎉 This PR is included in version 1.59.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Support Maps in isDeepEqual
4 participants