Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why accessing https://github.com/ReactTraining/history/commits/master give a 500 #476

Closed
d6u opened this issue May 16, 2017 · 2 comments
Closed

Why accessing https://github.com/ReactTraining/history/commits/master give a 500 #476

d6u opened this issue May 16, 2017 · 2 comments

Comments

@d6u
Copy link

d6u commented May 16, 2017

IDK if this is related to repo setup or github, but where can I find the commit history? I found a strange behavior in ReactRouterDOM (v4), that related to how createPath function is calling encodeURI before it returns, but I cannot find the code anywhere in this repo 😓
@pshrmn
Copy link
Contributor

pshrmn commented May 17, 2017

Probably related to #461 and #465

@mjackson
Copy link
Member

I'm not sure what the original problem was here but it seems to be ok now.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mjackson @pshrmn @d6u