Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a % in the url causes error #481

Closed
michaelBenin opened this issue May 23, 2017 · 3 comments
Closed

Adding a % in the url causes error #481

michaelBenin opened this issue May 23, 2017 · 3 comments

Comments

@michaelBenin
Copy link

Examples:

https://reacttraining.com/796226/yo%u-dont
@michaelBenin
Copy link
Author

Open for a try catch here? https://github.com/ReactTraining/history/blob/master/modules/PathUtils.js#L33

@pshrmn
Copy link
Contributor

pshrmn commented May 23, 2017

The issue with the example URI that you provided is that it is not valid. The literal percent characters must be encoded. There is some related discussion in #461.

@michaelBenin
Copy link
Author

handling here: #465

@pshrmn pshrmn mentioned this issue Aug 28, 2017
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jun 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelBenin @pshrmn