Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape special characters in prefix param in PathUtils.hasBasename #553

Closed
tyuuni opened this issue Dec 12, 2017 · 1 comment
Closed

Escape special characters in prefix param in PathUtils.hasBasename #553

tyuuni opened this issue Dec 12, 2017 · 1 comment

Comments

@tyuuni
Copy link

tyuuni commented Dec 12, 2017

Seems the prefix passed to hasBasename is basename we pass to createBrowserHistory, and basename is then used to rewrite urls when we switch to other routes.
So users can't pass an escaped basename to createBrowserHistory to come over this issue.

Could you please fix this minor issue?
@tyuuni tyuuni closed this as completed Dec 13, 2017
@tyuuni
Copy link
Author

tyuuni commented Dec 13, 2017

close because it's addressed here

@lock lock bot locked as resolved and limited conversation to collaborators Jun 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tyuuni