Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Everything except history.production.min.js should be un-minimized #909

Open
jfirebaugh opened this issue Nov 24, 2021 · 1 comment
Open

Comments

@jfirebaugh
Copy link

In the 5.1.0 published package contents, all the .js files are minimized, even history.development.js. This makes inspecting or debugging the installed package difficult. (Yes, there are .map files and //# sourceMappingURL commments, but those are unlikely to make it through a bundling pipeline and asset server intact, and they don't help with inspecting the contents of node_modules/history on the filesystem.)

Only history.production.min.js should be minimized, as that is the only file that's documented for direct use in a <script> tag. Everything else will be going through a bundling pipeline, where the user will decide when and with which tool to minify. This is consistent with the practices of other prominent packages which include both *.development.js and *.production.min.js files, e.g. react.

@yasonk
Copy link

yasonk commented Jan 6, 2022

Aside from the fact that the map files are malformed and don't work. You don't need minimized libraries. The packaging/bundler software will minimize them and create map files as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants