[changed] Preserve forward slashes in URL params

This is helpful when using * to match fs-like paths.
remix-run · Jul 17, 2014 · 616f8bf · 616f8bf
1 parent 6c74c69
commit 616f8bf
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/modules/helpers/Path.js b/modules/helpers/Path.js
@@ -88,7 +88,8 @@ var Path = {
         'Missing "' + paramName + '" parameter for path "' + pattern + '"'
       );
 
-      return URL.encode(params[paramName]);
+      // Preserve forward slashes.
+      return String(params[paramName]).split('/').map(URL.encode).join('/');
     });
   },
 

diff --git a/specs/Path.spec.js b/specs/Path.spec.js
@@ -144,6 +144,12 @@ describe('Path.injectParams', function () {
         expect(Path.injectParams(pattern, { id: 'one, two' })).toEqual('comments/one%2C+two/edit');
       });
     });
+
+    describe('and a param has a forward slash', function () {
+      it('preserves the forward slash', function () {
+        expect(Path.injectParams(pattern, { id: 'the/id' })).toEqual('comments/the/id/edit');
+      });
+    });
   });
 });