[fixed] injectParams invariant should not throw on values that coerce…

… to false.
remix-run · Jun 28, 2014 · f3dcdd7 · f3dcdd7
1 parent dde5f42
commit f3dcdd7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/modules/helpers/Path.js b/modules/helpers/Path.js
@@ -85,7 +85,7 @@ var Path = {
       var paramName = getParamName(pathSegment);
 
       invariant(
-        params[paramName],
+        params[paramName] != null,
         'Missing "' + paramName + '" parameter for path "' + pattern + '"'
       );
 

diff --git a/specs/Path.spec.js b/specs/Path.spec.js
@@ -127,6 +127,10 @@ describe('Path.injectParams', function () {
       it('returns the correct path', function () {
         expect(Path.injectParams(pattern, { id: 'abc' })).toEqual('comments/abc/edit');
       });
+
+      it('returns the correct path when the value is 0', function () {
+        expect(Path.injectParams(pattern, { id: 0 })).toEqual('comments/0/edit');
+      });
     });
 
     describe('and some params have special URL encoding', function () {