[changed] '.' is no longer a path delimeter

remix-run · Jul 2, 2014 · f474ab1 · f474ab1
1 parent 7b17307
commit f474ab1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/modules/helpers/Path.js b/modules/helpers/Path.js
@@ -22,7 +22,7 @@ function compilePattern(pattern) {
 
   var source = pattern.replace(paramMatcher, function (match, pathSegment) {
     paramNames.push(getParamName(pathSegment));
-    return pathSegment === '*' ? '(.*?)' : '([^./?#]+)';
+    return pathSegment === '*' ? '(.*?)' : '([^/?#]+)';
   });
 
   compiled.matcher = new RegExp('^' + source + '$', 'i');

diff --git a/specs/Path.spec.js b/specs/Path.spec.js
@@ -32,6 +32,12 @@ describe('Path.extractParams', function () {
         expect(Path.extractParams(pattern, 'users/123')).toBe(null);
       });
     });
+
+    describe('and the path matches with a segment containing a .', function () {
+      it('returns an object with the params', function () {
+        expect(Path.extractParams(pattern, 'comments/foo.bar/edit')).toEqual({ id: 'foo.bar' });
+      });
+    });
   });
 
   describe('when a pattern has characters that have special URL encoding', function () {