Replies: 1 comment 4 replies
-
|
I agree. As a workaround, I wrote this helper function which uses the History API directly to replace state. Note, that the state provided by the react-router |
Beta Was this translation helpful? Give feedback.
-
|
Are you 100% sure all React Router's history state is in under |
Beta Was this translation helpful? Give feedback.
-
|
Yes, you can verify here: https://github.com/remix-run/react-router/blob/89049ce4ee1b265b78468f25eb494eef240a7e40/packages/router/history.ts Edit: it's not that "all React Router's history state is under |
Beta Was this translation helpful? Give feedback.
-
|
I mean, if I update history state silently like that, won't it somehow screw up the flow of React Router? I would consider keeping my own entries under a different property because of that. Am I going too far with that? |
Beta Was this translation helpful? Give feedback.
-
|
I would say the workaround relies on an "undocumented API" which could possibly change without notice. However, it works for now. Would be nice if a properly supported solution was provided in the future.... |
Beta Was this translation helpful? Give feedback.
-
As far as I know, currently it's not possible to replace the history state without redirection. It's a bit surprising, given it's super useful to put data to be remembered on the current page in case user navigates away and then comes back. Even the native
history.replaceState()puts thestateparam first in order to allow state change without changing the URL. The docs forreact-routerdiscourage usinghistory.statedirectly, while not providing support for its basic features. I'm confused.In my opinion, it should also cause stable behavior, like
useRef(). It's just a piece of data attached to the current context. If that triggers moreuseEffect()and re-renders, it would be annoying to work with.The most obvious scenario is remembering scrolling positions of certain scrollable elements (not just the
<body>), but there are many, many more use cases.Beta Was this translation helpful? Give feedback.
All reactions