-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Experimental View Transitions API Broken #10696
Comments
This seems to be due to the removal of const transition = document.startViewTransition(() => {
ReactDOM.flushSync(() => navigate(`/${image.file}`));
}); |
Thanks for your help @brophdawg11! Much appreciated 😁 One follow up I have is that when I include a Working (6.10): https://codesandbox.io/s/elegant-tamas-mlhhhg Unfortunately |
yeah - for support with async loaders/actions the If you're interested in trying out via |
Hey I would love to try those changes but I'm not sure how to leverage |
well I made the change to the transpiled js but it did not fix the issue. Here's the generated patch file
|
my patch, seems like working:
|
@SPAHI4 why the setTimeout? |
I tried my example with both patches and each patch individually and neither fixed the transition issue :( |
This is what I would recommend. Then you can run There's also a built-in ENV var shortcut we use for local dev: |
React changes state asynchronously. I tried to use It depends on your bundler. You should check what file is loaded in your browser. It could be dist/router.cjs, router.js, router.min.js |
What version of React Router are you using?
6.14.1
Steps to Reproduce
Working repo using v6.10: https://codesandbox.io/s/elegant-tamas-mlhhhg
Broken repo using v6.14: https://codesandbox.io/s/practical-shirley-kpzptq
Open the above links in Edge ( > 111) or Chrome (> 111) (See here for compatibility list). The first example will smoothly transition from one route to the next using the View Transitions API. The second link will not. Upgrading from v6.10 of the
react-router-dom
library is the only change. The issue exists as far back as 6.11Expected Behavior
The view should transition using the View Transitions API
Actual Behavior
The view does not transition using the View Transitions API (as of 6.11)
The text was updated successfully, but these errors were encountered: