Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Absolute URL detection is too aggressive (breaking change from 6.8.0->6.8.1) #11291

Open
janruo opened this issue Feb 20, 2024 · 0 comments
Labels

Comments

@janruo
Copy link

janruo commented Feb 20, 2024

What version of React Router are you using?

6.22.1

Steps to Reproduce

Render a Link with a value containing colons: <Link to="foo:bar" />

Expected Behavior

Colon is an allowed character in URL paths, according to rfc3986. (For example, Wikipedia uses them extensively.)

v6.8.0 is the last version which respects that, and renders an internal route link when given a to value containing colons.

Actual Behavior

v6.8.1 and later treats any to value with colons as an absolute URL and renders an external link.

This change seems to be the original cause: #9994

@janruo janruo added the bug label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant