Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Memory leak when using <Redirect /> in tests with jest + JSDOM #11345

Open
Lukas-Kullmann opened this issue Mar 14, 2024 · 1 comment
Open
Labels

Comments

@Lukas-Kullmann
Copy link

What version of React Router are you using?

6.22.3

Steps to Reproduce

I created a reproduction repo: https://github.com/Lukas-Kullmann/react-router-memory-leak
The steps to reproduce are described in that repo's readme.

Basically: Use <Redirect /> (or useRedirect()) in any of your components in your tests with jest + jsdom.

I use node v20.11.1 and npm v10.4.0.

Expected Behavior

The test does not leak memory, no matter if you use <Redirect /> or not.

Actual Behavior

Some objects stay in memory after the test if you use a <Redirect />. Most notably: JSDOM's Window object(s).

@mikelnorth
Copy link

Seem to be seeing a similar issue where tests are failing due a memory leak.

Has anyone deduced what is the latest version without this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants