Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative replaceState, pushState #2226

Closed
qimingweng opened this issue Oct 9, 2015 · 2 comments
Closed

Relative replaceState, pushState #2226

qimingweng opened this issue Oct 9, 2015 · 2 comments

Comments

@qimingweng
Copy link
Contributor

I was wondering if there is already a way, or to start a discussion about whether or not to support relative state changes.

For example, frequently an action wants to add (or replace) a key in a query, but doesn't care what other things are in there and doesn't want change it. If I'm queries, I also furthermore don't care too much about the path, and having to import and pass these things around only makes the code more fragile.

(Also, I recognize this may have more to do with the history module, but I felt this was a better place to start the discussion)

@taion
Copy link
Contributor

taion commented Oct 9, 2015

Already being discussed at #2172 (comment). Would be addressed by #2186 as well (just take the location and override the query).

@qimingweng
Copy link
Contributor Author

A @taion thanks for pointing me in the right direction, I'll contribute to those discussion from now and close this.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants