Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser back error #6799

Closed
xianweics opened this issue Jun 18, 2019 · 3 comments
Closed

browser back error #6799

xianweics opened this issue Jun 18, 2019 · 3 comments

Comments

@xianweics
Copy link

Version

"react": "latest",
"react-dom": "latest",
"react-router-dom": "latest"

Please replace this sentence with the React Router version that you are using.

Test Case

https://codesandbox.io/s/7zwjlm2j3q

Steps to reproduce

  1. Click 'About' button more than once.
  2. Click back icon once in the embed browser.

Now you will find that url hasn't been changed.

Expected Behavior

When I click back icon once, the url changes and goes back to homepage instead of 'About'.

Actual Behavior

The url hasn't been changed. The route can't go back to homepage until you click back icon many times. I know when I click navigation 'About' once, the react-router will push history once. It will push once after I click 'About' again, so that I cannot able to reach homepage.

Please help me solve this problem.

@support
Copy link

support bot commented Jun 18, 2019

👋 @xianweics, we use the issue tracker exclusively for bug reports and feature requests. However, this issue appears to be a support request. For usage questions, please use Stack Overflow or Reactiflux where there are a lot more people ready to help you out.
Please feel free to clarify your issue if you think it was closed prematurely.

@support support bot closed this as completed Jun 18, 2019
@StringEpsilon
Copy link
Contributor

StringEpsilon commented Jun 18, 2019

@timdorr This isn't a support question. The issue as described is replicable.

Compare:

Also see history remix-run/history#470

I agree with all previous issues that the proper fix should be implemented in history. But Maybe we should just let one instance of this issue open here, reference the history issue and lock it. That might help stop people from reopening it a 7th time.

@xianweics
Copy link
Author

@timdorr This isn't a support question. The issue as described is replicable.

Compare:

Also see history ReactTraining/history#470

I agree with all previous issues that the proper fix should be implemented in history. But Maybe we should just let one instance of this issue open here, reference the history issue and lock it. That might help stop people from reopening it a 7th time.

thx.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants