Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: respect basename in useFormAction #9352

Merged
merged 4 commits into from Sep 30, 2022
Merged

fix: respect basename in useFormAction #9352

merged 4 commits into from Sep 30, 2022

Conversation

brophdawg11
Copy link
Contributor

Closes #9347

@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2022 •
edited

🦋 Changeset detected

Latest commit: 16f949e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
react-router-dom Patch
react-router-dom-v5-compat Patch
react-router Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 linked an issue Sep 26, 2022 that may be closed by this pull request
[Bug]: <Form> navigation doesn't respect basename #9347
Closed
mjackson
mjackson approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@mjackson mjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @brophdawg11 🙏

@brophdawg11 brophdawg11 merged commit 434003d into dev Sep 30, 2022
@brophdawg11 brophdawg11 deleted the brophdawg11/form-basename branch September 30, 2022 14:28
@github-actions github-actions bot mentioned this pull request Sep 30, 2022
Merged
@janovekj janovekj mentioned this pull request Sep 30, 2022
Merged
@brophdawg11 brophdawg11 mentioned this pull request Nov 4, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjackson mjackson mjackson approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: <Form> navigation doesn't respect basename
2 participants
@brophdawg11 @mjackson