chore: update esbuild to latest #1998
Conversation
The "issue" that was raised isn't a valid issue with esbuild and should be addressed in user-land (i.e, using libraries as intended by the author)
There was a problem hiding this comment.
What are we doing to do about people for whom this will be a breaking change? It'll be a lot of people. This really should be a v2 thing I think. Cc @mjackson
|
I don't agree with that. It's improper use of the libraries, it should be broken already. I.e attempting to import "default" when no "default" is exported. |
|
I can be convinced. Would be good to find a codemod anyway 👍 |
|
Yeah, I think it's still early in adoption that something like this isn't really a "breaking" change, especially when they were technically not doing it correctly to begin with. I don't think Remix should perpetuate incorrect practices. Besides, the actual fix is pretty simple. They would literally need to add This should be called out in the Release Notes. |
|
Yeah, a codemod is probably unnecessary. I'd be surprised to find a Remix codebase larger than my own this early after the official release and it won't take me much time to address this issue. I'm convinced 👍 |
|
cc @chaance, you'll want to make note of this in the release notes 👆 |
|
Evan reference: evanw/esbuild#2019 (comment) |
The "issue" that was raised isn't a valid issue with esbuild and should be addressed in user-land (i.e, using libraries as intended by the author). Essentially a little bit of hand holding Esbuild did here has been removed to fall inline with other bundlers in the ecosystem.
Closes: #