Remix crashes with web-fetch 4.3.2/1.8.2 #4993

tarngerine · 2023-01-03T17:52:55Z

What version of Remix are you using?

1.8.2

Steps to Reproduce

See sandbox: https://codesandbox.io/p/sandbox/solitary-wave-1l0skr
Failing test PR: #4994

Observe exit code 1 (remix crashes, premature close error) when fetcher loads from /load.tsx route, which calls fetch from a Google drive URL
Go to load.tsx, uncomment the import that uses web-fetch 4.3.1
Remix no longer crashes

Expected Behavior

web-fetch's fetch should work, without crashing remix, returning a valid HTML result

Actual Behavior

remix crashes, exit code 1

/project/sandbox/node_modules/@remix-run/node/node_modules/@remix-run/web-fetch/src/fetch.js:342
                                const error = Object.assign(new Error('Premature close'), {
                                ^
Error: Premature close
    at TLSSocket.onSocketClose (/project/sandbox/node_modules/@remix-run/node/node_modules/@remix-run/web-fetch/src/fetch.js:342:33)
    at TLSSocket.emit (node:events:525:35)
    at node:net:757:14
    at TCP.done (node:_tls_wrap:584:7)
error Command failed with exit code 1.

Related issues:

#4737

The text was updated successfully, but these errors were encountered:

cliffordfajardo · 2023-01-03T19:45:54Z

This codesandbox URL you shared doesn't seem to work; I've had this challenge when using their newer codesandbox environments 😅

Any way you could copy code into this stackblitz template below?

Remix Stackblitz 1.8.2 template: https://stackblitz.com/edit/node-nrd9zz

tarngerine · 2023-01-03T20:16:15Z

Hi, can you explain what you mean by the codesandbox doesn't work? It is supposed to show an error that is the bug I am reporting:

once you go into load.tsx and uncomment the 4.3.1 web-fetch import, and hit the refresh icon "restart task" on the dev pane, then it will display the site:

tarngerine · 2023-01-03T20:17:38Z

Unfortunately i cannot repro this issue in Stackblitz, it has its own issues with fetching (different from the issue i'm reporting), guessing from CORS bc it's webcontainer?

tarngerine · 2023-01-03T20:28:04Z

Here's a failing test PR if that helps: #4994

cliffordfajardo · 2023-01-04T00:56:00Z

Hi, can you explain what you mean by the codesandbox doesn't work?
My bad, i should have been more specific;
when I try to view the codesandbox URL you shared I see this error & do no have access to view the code in the images you shared

tarngerine · 2023-01-13T18:09:23Z

Here's a failing test PR if that helps: #4994

nicksrandall · 2023-01-20T17:18:48Z

@jacob-ebey Is the failing test enough? Anything else we can do to help get this fixed?

gigobyte · 2023-02-07T16:16:07Z

I have an action that starts a setInterval that calls fetch and for me this reproduces the error every few requests. Luckily reverting @remix-run/web-fetch back to 4.3.1 fixes the issue.

donavon · 2023-02-07T23:37:15Z

I'm having the same issue. I just closed #5385 as it's a dupe of this issue.

If you need to temporary workaround (it works for me), you can use the diff I posted there with patch-package. No guarantees, but it seems to work until we get a proper fix (all I do is suppress the error). I use the "revert back to 4.3.1" solution.

Interesting that my issue is with fetching from docs.google.com as well (I saw the failing test in #4994). Google must be doing something funky.

donavon · 2023-02-07T23:57:26Z

@tarngerine Just to confirm, I can see your sandbox properly failing with 4.3.2

donavon · 2023-02-07T23:59:48Z

FYI... Here's the diff between 4.3.1 and 4.3.2

fetch.js

diff --git a/src/fetch.js b/src/fetch.js
index v4.3.1..v4.3.2 100644
--- a/src/fetch.js
+++ b/src/fetch.js
@@ -346,13 +346,8 @@
 			}
 		};
 
-		socket.prependListener('close', onSocketClose);
-
-		request.on('abort', () => {
-			socket.removeListener('close', onSocketClose);
-		});
-
-		socket.on('data', buf => {
+		/** @param {Buffer} buf */
+		const onData = buf => {
 			properLastChunkReceived = Buffer.compare(buf.slice(-5), LAST_CHUNK) === 0;
 
 			// Sometimes final 0-length chunk and end of message code are in separate packets
@@ -364,6 +359,14 @@
 			}
 
 			previousChunk = buf;
+		};
+
+		socket.prependListener('close', onSocketClose);
+		socket.on('data', onData);
+
+		request.on('close', () => {
+			socket.removeListener('close', onSocketClose);
+			socket.removeListener('data', onData);
 		});
 	});
 }

request.js

diff --git a/src/request.js b/src/request.js
index v4.3.1..v4.3.2 100644
--- a/src/request.js
+++ b/src/request.js
@@ -38,6 +38,7 @@
  * @property {string} method
  * @property {RequestRedirect} redirect
  * @property {globalThis.Headers} headers
+ * @property {RequestCredentials} credentials
  * @property {URL} parsedURL
  * @property {AbortSignal|null} signal
  * 
@@ -135,6 +136,7 @@
 			method,
 			redirect: init.redirect || input.redirect || 'follow',
 			headers,
+			credentials: init.credentials || 'same-origin',
 			parsedURL,
 			signal: signal || null
 		};
@@ -169,7 +171,7 @@
 	 */
 
 	get credentials() {
-		return "same-origin"
+		return this[INTERNALS].credentials
 	}
 
 	/**

donavon · 2023-02-08T01:57:03Z

The only issue with reverting back to 4.3.1 is that 4.3.2 was there to fix a memory leak (see remix-run/web-std-io@3b9b384).

donavon · 2023-02-08T02:39:09Z

PR created with a possible fix: remix-run/web-std-io#29

Plz review

donavon · 2023-02-19T14:45:50Z

I'm surprised that something that crashes Remix isn't getting any attention.

busbyk · 2023-04-19T15:26:43Z

I'm running into the same issue - it's only with specific websites. Looks like there's a similar problem with the node-fetch library? node-fetch/node-fetch#1576

I installed axios and am able to make requests to the same website that was causing an error with Remix's web-fetch implementation 😞

zabirauf · 2023-04-21T07:20:11Z

FWIW, I also came here to report similar issue. I have also run into it often but it's not consistent.

BenVosper · 2023-06-19T16:12:21Z

Like the other commenters, we have experienced this issue in our Remix project. It was very inconsistent, with identical requests failing consistently one after another one minute, then seemingly working fine the next. I was never able to replicate the issue locally: we had to catch it in production.

Replacing our usage of fetch with axios seems to have completely fixed the problem.

Let me know if I can provide any details of our project that might help debug. I just wanted to bump this issue for visibility.

IgnisDa · 2023-06-19T16:34:30Z

The error does not occur if you have connection: keep-alive in the headers. I think axios sets that automatically.

brophdawg11 · 2023-08-01T23:06:44Z

This is resolved by the version bump in #7026 and should be available when 1.19.2 is released

brophdawg11 · 2023-08-01T23:08:46Z

This can also be tested in 1.19.2-pre.0 currently if anyone would like to validate the fix

github-actions · 2023-08-01T23:10:16Z

🤖 Hello there,

We just published version 1.19.2-pre.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

github-actions · 2023-08-02T07:07:58Z

🤖 Hello there,

We just published version v0.0.0-nightly-3b808ce-20230802 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

remix-run/remix#4993 (comment)

ericallam · 2023-08-02T13:53:25Z

We've had this issue (intermittently on prod only) and we've updated to 1.19.2-pre.0 and are testing it out now. Will update this issue if we continue to experience the Premature close error

github-actions · 2023-08-02T15:46:28Z

🤖 Hello there,

We just published version 1.19.2-pre.1 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

ericallam · 2023-08-02T19:07:57Z

@brophdawg11 was there really something related to this issue in 1.19.2-pre.1, and should we upgrade to try it?

github-actions · 2023-08-03T07:08:52Z

🤖 Hello there,

We just published version v0.0.0-nightly-7cb1e7e-20230803 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

brophdawg11 · 2023-08-03T14:40:02Z

@ericallam No - I think that's just our bot seeing that there's something new in the prerelease when compared to the latest stable release, so it comments from the comparison of 1.19.0 -> 1.19.1-pre.0 and 1.19.0 -> 1.19.1-pre.1

Has 1.19.0-pre.0 been working ok for you w.r.t. the fetch crash?

ericallam · 2023-08-03T14:41:23Z

@brophdawg11 no errors so far 👍

github-actions · 2023-08-04T10:30:23Z

🤖 Hello there,

We just published version 1.19.2-pre.2 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

github-actions · 2023-08-04T11:09:25Z

🤖 Hello there,

We just published version 1.19.2 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

tarngerine added the bug:unverified label Jan 3, 2023

tarngerine mentioned this issue Jan 3, 2023

BUG: web-fetch premature close #4994

Closed

2 tasks

nicksrandall mentioned this issue Jan 20, 2023

Node server crashing when upgrade to 1.8 (@remix-run/web-fetch@4.3.2) #4737

Closed

donavon mentioned this issue Feb 7, 2023

Resource route proxy crashes Remix hard #5385

Closed

1 task

donavon mentioned this issue Feb 8, 2023

remove socket listeners on “abort” remix-run/web-std-io#29

Merged

isker mentioned this issue Mar 21, 2023

SSR isker/neogrok#2

Closed

brophdawg11 added the feat:fetch Issues related to @remix-run/web-fetch label May 5, 2023

brophdawg11 closed this as completed in remix-run/web-std-io#29 Aug 1, 2023

brophdawg11 linked a pull request Aug 1, 2023 that will close this issue

Update to latest @remix-run/web-* packages #7026

Merged

brophdawg11 added the awaiting release This issue has been fixed and will be released soon label Aug 1, 2023

brophdawg11 mentioned this issue Aug 1, 2023

Update to latest @remix-run/web-* packages #7026

Merged

ericallam added a commit to triggerdotdev/trigger.dev that referenced this issue Aug 2, 2023

Upgrade to Remix 1.19.2-pre.0 to try and fix premature close issue

442ee45

remix-run/remix#4993 (comment)

brophdawg11 removed the awaiting release This issue has been fixed and will be released soon label Aug 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remix crashes with web-fetch 4.3.2/1.8.2 #4993

Remix crashes with web-fetch 4.3.2/1.8.2 #4993

tarngerine commented Jan 3, 2023 •

edited

cliffordfajardo commented Jan 3, 2023

tarngerine commented Jan 3, 2023

tarngerine commented Jan 3, 2023 •

edited

tarngerine commented Jan 3, 2023

cliffordfajardo commented Jan 4, 2023

tarngerine commented Jan 13, 2023

nicksrandall commented Jan 20, 2023

gigobyte commented Feb 7, 2023

donavon commented Feb 7, 2023 •

edited

donavon commented Feb 7, 2023

donavon commented Feb 7, 2023

donavon commented Feb 8, 2023

donavon commented Feb 8, 2023

donavon commented Feb 19, 2023

busbyk commented Apr 19, 2023

zabirauf commented Apr 21, 2023

BenVosper commented Jun 19, 2023

IgnisDa commented Jun 19, 2023

brophdawg11 commented Aug 1, 2023

brophdawg11 commented Aug 1, 2023

github-actions bot commented Aug 1, 2023

github-actions bot commented Aug 2, 2023

ericallam commented Aug 2, 2023

github-actions bot commented Aug 2, 2023

ericallam commented Aug 2, 2023

github-actions bot commented Aug 3, 2023

brophdawg11 commented Aug 3, 2023

ericallam commented Aug 3, 2023

github-actions bot commented Aug 4, 2023

github-actions bot commented Aug 4, 2023

Remix crashes with web-fetch 4.3.2/1.8.2 #4993

Remix crashes with web-fetch 4.3.2/1.8.2 #4993

Comments

tarngerine commented Jan 3, 2023 • edited

What version of Remix are you using?

Steps to Reproduce

Expected Behavior

Actual Behavior

Related issues:

cliffordfajardo commented Jan 3, 2023

tarngerine commented Jan 3, 2023

tarngerine commented Jan 3, 2023 • edited

tarngerine commented Jan 3, 2023

cliffordfajardo commented Jan 4, 2023

tarngerine commented Jan 13, 2023

nicksrandall commented Jan 20, 2023

gigobyte commented Feb 7, 2023

donavon commented Feb 7, 2023 • edited

donavon commented Feb 7, 2023

donavon commented Feb 7, 2023

fetch.js

request.js

donavon commented Feb 8, 2023

donavon commented Feb 8, 2023

donavon commented Feb 19, 2023

busbyk commented Apr 19, 2023

zabirauf commented Apr 21, 2023

BenVosper commented Jun 19, 2023

IgnisDa commented Jun 19, 2023

brophdawg11 commented Aug 1, 2023

brophdawg11 commented Aug 1, 2023

github-actions bot commented Aug 1, 2023

github-actions bot commented Aug 2, 2023

ericallam commented Aug 2, 2023

github-actions bot commented Aug 2, 2023

ericallam commented Aug 2, 2023

github-actions bot commented Aug 3, 2023

brophdawg11 commented Aug 3, 2023

ericallam commented Aug 3, 2023

github-actions bot commented Aug 4, 2023

github-actions bot commented Aug 4, 2023

tarngerine commented Jan 3, 2023 •

edited

tarngerine commented Jan 3, 2023 •

edited

donavon commented Feb 7, 2023 •

edited