Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2074 AutoComplete with jline3 is showing hidden values #2075

Merged
merged 2 commits into from
Jul 30, 2023

Conversation

clebertsuconic
Copy link
Contributor

No description provided.

@clebertsuconic
Copy link
Contributor Author

This fixed my issue on the artemis shell / jline3 integration. I'm not sure yet how to add a test for this (still looking) meanwhile this serves as a discussion starter.

@clebertsuconic
Copy link
Contributor Author

@remkop I tried to write a test :) .. but I don't understand how this dejavu test works, and what you expect on these spawned tests.

I supposed they are emulating an auto-completion and terminal .. but I couldn't progress much further without some guidance.

It seems though this should be an easy fix for someone knowledgeable about this codebase.. if you could handle this issue.. or someone else already knowledgeable here?

@remkop
Copy link
Owner

remkop commented Jul 29, 2023

@clebertsuconic Thanks for raising this and thanks for the pull request!

Looks good.
I’m on my phone now and want to take another look on my pc before merging it.

About the tests, the dejagnu stuff is mostly for testing bash completion and it’s a bit of a learning curve…
I haven’t considered using it to test the JLine stuff, that’s an interesting idea. But your change is straightforward enough.

@clebertsuconic
Copy link
Contributor Author

@remkop how often you make releases? just planning the artemis release after this. (I could also extend and fix in the usage for now).. just for my planning.

thanks.

@remkop remkop added this to the 4.7.5 milestone Jul 30, 2023
@remkop remkop added type: bug 🐛 theme: auto-completion An issue or change related to auto-completion theme: shell An issue or change related to interactive (JLine) applications theme: integration An issue or change related to integration with other frameworks, shells or operating systems labels Jul 30, 2023
@remkop remkop merged commit 460496b into remkop:main Jul 30, 2023
10 checks passed
@remkop
Copy link
Owner

remkop commented Jul 30, 2023

Merged. Thank you for the contribution!

remkop added a commit that referenced this pull request Jul 30, 2023
@clebertsuconic
Copy link
Contributor Author

@remkop thank you so much.

I hate to be one of those guys asking for a release? :) but how far is a release? :)

@remkop
Copy link
Owner

remkop commented Aug 3, 2023

I will probably try to fix some more items that are currently in scope for 4.7.5 before doing a release. Especially the bugs. I don't have time lines, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: auto-completion An issue or change related to auto-completion theme: integration An issue or change related to integration with other frameworks, shells or operating systems theme: shell An issue or change related to interactive (JLine) applications type: bug 🐛
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't generate auto-complete for hidden attributes in picocli.shell.jline3.PicoCommand
2 participants