Update logic for detecting if the output stream is connected to a terminal #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remkop
requested changes
Aug 11, 2023
| return false; | ||
| } | ||
| try { | ||
| Method isTerminal = Console.class.getDeclaredMethod("isTerminal"); |
There was a problem hiding this comment.
Looks good, but the Console class was introduced in Java 6, and picocli supports Java 5, so can you change this to find the Console class via reflection?
|
Thank you for raising this! Overall the PR looks good, please look at the minor change I requested to find the |
remkop
approved these changes
Aug 14, 2023
|
Merged. Thank you for the contribution! |
remkop
added a commit
that referenced
this pull request
Aug 26, 2023
remkop
added a commit
that referenced
this pull request
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2083