Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node-modules-polyfill] Replace unmaintained rollup-plugin-node-polyfills dependency #18

Closed
MichaelDeBoey opened this issue Jun 29, 2022 · 4 comments · Fixed by #19
Closed

Comments

@MichaelDeBoey
Copy link
Contributor

MichaelDeBoey commented Jun 29, 2022

Same reasoning as in ionic-team/rollup-plugin-node-polyfills#32.

Since that repo is never touched in the last 3 years, it's probably a good idea to either look at the community forks (see ionic-team/rollup-plugin-node-polyfills#28) or create our own fork.
I would prefer to use @FredKSchott fork as he's the creator of snowpack & that's the one used by the snowpack library too, so it probably has the most up to date version of the rollup-plugin-node-polyfills lib.

Edit: @FredKSchott's fork is also recommended by the @rollup team: https://rollupjs.org/guide/en/#warning-treating-module-as-external-dependency

@MichaelDeBoey MichaelDeBoey changed the title [node-modules-polyfill] Replace rollup-plugin-node-polyfills dependency [node-modules-polyfill] Replace unmaintained rollup-plugin-node-polyfills dependency Jun 29, 2022
@giuseppeg
Copy link

@vafanassieff
Copy link

Any update on this ?

@vafanassieff
Copy link

Thanks ! I used an easier way for my use, i only needed buffer

See comment here and here

@MichaelDeBoey
Copy link
Contributor Author

@giuseppeg Is this fixed in @FredKSchott's rollup-plugin-polyfill-node fork?

@vafanassieff #19 implements the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment