Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

volume component of Player is not responsively designed #1352

Closed
UmungoBungo opened this issue Sep 30, 2022 · 9 comments 路 Fixed by #1356
Closed

volume component of Player is not responsively designed #1352

UmungoBungo opened this issue Sep 30, 2022 · 9 comments 路 Fixed by #1356
Labels
bug Something isn't working 馃巵 Rewarded on Issuehunt This issue has been rewarded on Issuehunt 馃エ hacktoberfest During October, this issue holds a cash bounty!

Comments

@UmungoBungo
Copy link
Contributor

UmungoBungo commented Sep 30, 2022

Issuehunt badges

馃巸 This issue is part of our Hacktoberfest campaign!
馃摎 Read more about Hacktoberfest here
馃暃 This issue is currently assigned to @Pompette and is not for the taking.

Bug Report 馃悰

When using the Player component in a portrait view, with a narrow width, the volume controller is not responsively designed. Pehaps it should be a vertical control when there is a narrow width?

issueVolume.mp4

IssueHunt Summary

pompette pompette has been rewarded.

Backers (Total: $167.00)

Submitted pull Requests


Tips

@UmungoBungo UmungoBungo added the bug Something isn't working label Sep 30, 2022
@JonnyBurger
Copy link
Member

Good point! We should improve this - a vertical control sounds like a smart idea!
I will add a bounty for it during Hacktoberfest and see if somebody picks it up, otherwise we'll solve it ourselves.

@JonnyBurger JonnyBurger added the 馃エ hacktoberfest During October, this issue holds a cash bounty! label Sep 30, 2022
@issuehunt-oss
Copy link

issuehunt-oss bot commented Oct 3, 2022

@jonnyburger has funded $167.00 to this issue.


@issuehunt-oss issuehunt-oss bot added the 馃挼 Funded on Issuehunt This issue has been funded on Issuehunt label Oct 3, 2022
@imrishabh18
Copy link

@JonnyBurger I would like to take up this issue. Can you assign this to me please?

@JonnyBurger
Copy link
Member

@imrishabh18 It was already started by @Pompette unfortunately!
Mind taking another issue with the Hacktoberfest label?

@imrishabh18
Copy link

Okay, the issues here on GitHub labeled hacktoberfest is not assigned to anybody. So, can't make out which one's are up-for-grabs?

@JonnyBurger
Copy link
Member

JonnyBurger commented Oct 3, 2022

Acceptance criteria for this PR:

  • Make slider go upwards if space is not sufficient
  • Be resilient if used in Next.JS server-side rendering / React strict mode

@JonnyBurger
Copy link
Member

JonnyBurger commented Oct 3, 2022

@imrishabh18 Sorry, I'm still preparing all the issues and will mention in each one of them clearly which ones are taken and how to claim one. Check back in a few hours!

@issuehunt-oss
Copy link

issuehunt-oss bot commented Oct 4, 2022

@jonnyburger has rewarded $150.30 to @pompette. See it on IssueHunt

  • 馃挵 Total deposit: $167.00
  • 馃帀 Repository reward(0%): $0.00
  • 馃敡 Service fee(10%): $16.70

@issuehunt-oss issuehunt-oss bot added 馃巵 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 馃挼 Funded on Issuehunt This issue has been funded on Issuehunt labels Oct 4, 2022
@JonnyBurger
Copy link
Member

Fixed by #1356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 馃巵 Rewarded on Issuehunt This issue has been rewarded on Issuehunt 馃エ hacktoberfest During October, this issue holds a cash bounty!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants