Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the PageView reverse parameter #159

Merged
merged 1 commit into from Jul 10, 2019
Merged

Add the PageView reverse parameter #159

merged 1 commit into from Jul 10, 2019

Conversation

nvbln
Copy link
Contributor

@nvbln nvbln commented Jul 4, 2019

Implements the PageView reverse parameter, saves having to reverse the given data.

@renancaraujo
Copy link
Member

Looks good, just run flutter format . on the project to solve format errors.

@nvbln
Copy link
Contributor Author

nvbln commented Jul 9, 2019 •
edited

That's where things get interesting, as running flutter format . leaves everything unchanged..

EDIT: The new Flutter version does give some changes, however none seem to be related to my changes.

@renancaraujo
Copy link
Member

Holy shmoly, LGTM then (I will check this. travis issue later).

@renancaraujo
Copy link
Member

lgtm

@renancaraujo renancaraujo merged commit ace9186 into bluefireteam:master Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renancaraujo renancaraujo renancaraujo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nvbln @renancaraujo