Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hero's createRectTween #175

Closed
ghost opened this issue Aug 23, 2019 · 2 comments
Closed

Hero's createRectTween #175

ghost opened this issue Aug 23, 2019 · 2 comments

Comments

@ghost
Copy link

ghost commented Aug 23, 2019 •
edited by ghost

I have to set a custom createRectTween to PhotoView's Hero.

Currently, two attributes of PhotoViewImageWrapper are exclusively Hero's parameters: heroTag and transitionOnUserGestures. At this point, I think there should be a property called heroAttributes, which will lighten PhotoViewImageWrapper's parameters and also let more clear which parameters are Hero-related (I mean, createRectTween as a parameter of a PhotoView may seen completely out of place).

I can submit a PR with all of these improvements, but breaking changes are going to emerge, so I need your approval to make sure I won't waste my time.
@renancaraujo
Copy link
Member

Absolutely, go for it.

@ghost ghost mentioned this issue Aug 29, 2019
Merged
renancaraujo pushed a commit that referenced this issue Sep 3, 2019
@renancaraujo
Implement HeroProperties (#177)
5e45056 
* Replace package imports by relative imports

Effective dart: PREFER relative paths when importing libraries within your own package’s lib directory.
You can check it here: https://dart.dev/guides/language/effective-dart/usage#prefer-relative-paths-when-importing-libraries-within-your-own-packages-lib-directory

* Implement `HeroAttributes`

Please refer to #175.
@renancaraujo
Copy link
Member

Tackle'd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@renancaraujo