Added pageSnapping option #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@renancaraujo @spydon @LucazzP how is this progressing in review? I would appreciate it |
spydon
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Lgtm, sorry for the delay!
Will poke @renancaraujo about it
MagTuxGit
added a commit
to MagTuxGit/photo_view
that referenced
this pull request
May 6, 2024
* master_remote: chore: 0.15.0 (bluefireteam#553) Added pageSnapping option (bluefireteam#542) feature/strictscale: add possibility to restrict user scale, fix issue bluefireteam#85 (bluefireteam#537) make scale more smoothly (bluefireteam#450) Pass through semanticLabel (bluefireteam#530) doc: Fix github build badge (bluefireteam#531)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the pageSnapping option to give the dev the option to view continually the image from the gallery, without snapping every time.
The main reason for me doing this addition is to add this option also on the pdfx package, it is useful for the web apps with vertical viewing.