Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract data adapter to proper repository and package #457

Open
pjanuario opened this issue Mar 31, 2015 · 2 comments
Open

Extract data adapter to proper repository and package #457

pjanuario opened this issue Mar 31, 2015 · 2 comments

Comments

@pjanuario
Copy link

I think since the adapter could be a separated module, this would allow people to extend with new adapters and improve support on the existent one.

I implemented a data adapter that extends the RestAdapter and support query string authentication, but it's my intention to support (at least) basic auth and header authentication in a near future.

https://www.npmjs.com/package/rendr-auth-rest-adapter

To implement this I had to depend on rendr package, that is undesirable.

@saponifi3d
Copy link
Contributor

I completely agree. I'm working on trying to modularize all of Rendr, ideally the main repo will be bits and bobs of glue code to tie a couple default packages together.

@pjanuario
Copy link
Author

+1...

@saponifi3d I don't know if you agree but I think a RestAdapter repository could have several implementations of rest adapter. I would expose the default implementation (the one that rendr have today) and people would be able to require the other implementations and use them.

This would allows us to have a repo for rest adapter that have several implementations and get several contributions for different proposes. I have seen people making adapters for basic auth, token authentication on query string and/or header (me), cookie forwarding.

I would be glad to make a PR with token auth code that I already have on my repo and later with header auth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants