Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting writeToCache: false still writes models to cache #510

Open
jaredrada opened this issue Jan 12, 2016 · 1 comment
Open

setting writeToCache: false still writes models to cache #510

jaredrada opened this issue Jan 12, 2016 · 1 comment
Labels

Comments

@jaredrada
Copy link

Believe I found a bug related to optionally storing models in the modelStore.

this.app.fetcher.fetch(
        {
            user: {model: 'Account',}
        },
        {
            'readFromCache': false,
            'writeToCache': false //handle this manually in the success method (handleLoginResponse)
        },
        this.handleLoginResponse.bind(this)
    );

If we set a breakpoint in this.handleLoginResponse we will find that this.app.fetcher.modelStore.cache has an entry for the Account model. If you check shared/fetcher.js we see the option to skip the write to cache is respected. However if we look at line shared/base/model.js in the model is still written to the store.

@jaredrada jaredrada changed the title setting setting writeToCache: false still writes models to cache Jan 12, 2016
@saponifi3d saponifi3d added the bug label Feb 11, 2016
@saponifi3d
Copy link
Contributor

Thanks for the bug report, thanks for giving loads of details and links into the code itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants