feat: Allow using non-slim renovate image #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avorima
force-pushed
the
configurable-slim-image
branch
from
ea10a97
to
fd90c3d
Compare
viceice
requested changes
Jan 4, 2023
viceice
reviewed
Jan 4, 2023
avorima
force-pushed
the
configurable-slim-image
branch
2 times, most recently
from
78408f9
to
00169c6
Compare
Signed-off-by: Mario Valderrama <mario.valderrama@ionos.com>
avorima
force-pushed
the
configurable-slim-image
branch
from
00169c6
to
d4d2741
Compare
|
@viceice Thanks for your review. I rebased and amended my commit to get the latest changes from main. PTAL |
Please use update with merge commit next time, so we don't loose review history. We squash the PR anyways, so don't worry about PR history |
|
Also use the re-request review feature when a new review is needed |
viceice
reviewed
Jan 4, 2023
viceice
approved these changes
Jan 23, 2023
viceice
changed the title
|
Please resolve fixed discussions |
viceice
reviewed
Jan 23, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably is my first time writing TypeScript, so please bear with me.
Added optional
useSlimaction input. If it is set tofalse, then the normalrenovate/renovateimage will be used. The default behavior remains unchanged.Fixes: #625