feat: allow to override docker command and user #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an option to specify a docker command and a docker user. It is useful if you need to customize your image before running `renovate`. It maybe a partial option for renovatebot/renovate#8804 The idea start from this discussion renovatebot/renovate#23500
|
please add an e2e test |
|
I added a test (actually modifying the existing one to use the new feature). You say "you don't like it" :-), happy to hear your thought about it, it was a way to solve my own problem but if you see a better solution let me know |
|
hey @viceice just a quick heads up |
viceice
requested changes
Jul 29, 2023
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
|
@viceice sorry for the delay, I was off 🌴 |
|
@viceice 👋 ;-) |
viceice
reviewed
Aug 25, 2023
README.md
Outdated
Comment on lines
19
to
20
| - [`docker-cmd-file`](#docker-cmd-file) | ||
| - [`docker-user`](#docker-user) |
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
|
Hey @viceice, any chance to have this merged & released? |
use the re-request review button |
viceice
reviewed
Oct 9, 2023
viceice
reviewed
Oct 9, 2023
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
viceice
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to specify a docker command and a docker user.
It is useful if you need to customize your image before running
renovate.It maybe a partial option for
renovatebot/renovate#8804
The idea start from this discussion
renovatebot/renovate#23500