fix(cache): improve repository cache robustness (#6689)

renovatebot · Jul 7, 2020 · 4459b11 · 4459b11
1 parent e015875
commit 4459b11
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/lib/util/cache/repository/index.spec.ts b/lib/util/cache/repository/index.spec.ts
@@ -45,6 +45,6 @@ describe('lib/util/cache/repository', () => {
     expect(fs.outputFile.mock.calls).toHaveLength(1);
   });
   it('gets', () => {
-    expect(repositoryCache.getCache()).toEqual({ repository: 'abc/def' });
+    expect(repositoryCache.getCache()).toEqual({});
   });
 });
diff --git a/lib/util/cache/repository/index.ts b/lib/util/cache/repository/index.ts
@@ -56,15 +56,19 @@ export async function initialize(config: RenovateConfig): Promise<void> {
   } catch (err) {
     logger.debug({ cacheFileName }, 'Repository cache not found');
   }
-  cache = cache || { repository: config.repository };
+  cache = cache || Object.create({});
+  cache.repository = config.repository;
 }
 
 export function getCache(): Cache {
+  cache = cache || Object.create({});
   return cache;
 }
 
 export async function finalize(): Promise<void> {
-  if (repositoryCache !== 'disabled') {
+  if (cacheFileName && cache && repositoryCache !== 'disabled') {
     await fs.outputFile(cacheFileName, JSON.stringify(cache));
   }
+  cacheFileName = null;
+  cache = Object.create({});
 }