feat: packageRules filter on depTypes

Needed for package managers that support more than one depType (e.g. Bundler). Closes #3076
renovatebot · Jan 21, 2019 · b212f8d · b212f8d
1 parent b8df0f8
commit b212f8d
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/lib/util/package-rules.js b/lib/util/package-rules.js
@@ -13,6 +13,7 @@ function applyPackageRules(inputConfig) {
     versionScheme,
     packageFile,
     depType,
+    depTypes,
     depName,
     currentValue,
     fromVersion,
@@ -71,7 +72,9 @@ function applyPackageRules(inputConfig) {
       negativeMatch = negativeMatch || !isMatch;
     }
     if (depTypeList.length) {
-      const isMatch = depTypeList.includes(depType);
+      const isMatch =
+        depTypeList.includes(depType) ||
+        (depTypes && depTypes.some(dt => depTypeList.includes(dt)));
       positiveMatch = positiveMatch || isMatch;
       negativeMatch = negativeMatch || !isMatch;
     }

diff --git a/test/util/package-rules.spec.js b/test/util/package-rules.spec.js
@@ -120,6 +120,23 @@ describe('applyPackageRules()', () => {
     const res = applyPackageRules({ ...config, ...dep });
     expect(res.x).toBe(1);
   });
+  it('filters depTypes', () => {
+    const config = {
+      packageRules: [
+        {
+          depTypeList: ['test'],
+          packageNames: ['a'],
+          x: 1,
+        },
+      ],
+    };
+    const dep = {
+      depTypes: ['build', 'test'],
+      depName: 'a',
+    };
+    const res = applyPackageRules({ ...config, ...dep });
+    expect(res.x).toBe(1);
+  });
   it('filters managers with matching manager', () => {
     const config = {
       packageRules: [