Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
fix(presets): include '@typescript-eslint' with eslint preset (#6687)
* fix(presets): include '@typescript-eslint' with eslint preset

This updates the eslint package preset to include the @typescript-eslint monorepo. This is a suite of plugins and configs that enables eslint to support typescript.

* test(presets): update eslint test snapshots and expectations
  • Loading branch information
jfairley committed Jul 6, 2020
1 parent 76eab4d commit ed13e22
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
5 changes: 5 additions & 0 deletions lib/config/presets/__snapshots__/index.spec.ts.snap
Expand Up @@ -318,6 +318,7 @@ Object {
"babel-eslint",
],
"packagePatterns": Array [
"^@typescript-eslint/",
"^eslint",
"^stylelint",
],
Expand Down Expand Up @@ -406,6 +407,7 @@ Object {
"babel-eslint",
],
"packagePatterns": Array [
"^@typescript-eslint/",
"^eslint",
],
}
Expand All @@ -422,6 +424,7 @@ Object {
"remark-lint",
],
"packagePatterns": Array [
"^@typescript-eslint/",
"^eslint",
"^stylelint",
"\\\\btslint\\\\b",
Expand All @@ -446,6 +449,7 @@ Object {
"remark-lint",
],
"packagePatterns": Array [
"^@typescript-eslint/",
"^eslint",
"^stylelint",
"\\\\btslint\\\\b",
Expand All @@ -464,6 +468,7 @@ Object {
"babel-eslint",
],
"packagePatterns": Array [
"^@typescript-eslint/",
"^eslint",
],
},
Expand Down
6 changes: 3 additions & 3 deletions lib/config/presets/index.spec.ts
Expand Up @@ -143,14 +143,14 @@ describe('config/presets', () => {
config.extends = ['packages:eslint'];
const res = await presets.resolveConfigPresets(config);
expect(res).toMatchSnapshot();
expect(res.packagePatterns).toHaveLength(1);
expect(res.packagePatterns).toHaveLength(2);
});
it('resolves linters', async () => {
config.extends = ['packages:linters'];
const res = await presets.resolveConfigPresets(config);
expect(res).toMatchSnapshot();
expect(res.packageNames).toHaveLength(3);
expect(res.packagePatterns).toHaveLength(3);
expect(res.packagePatterns).toHaveLength(4);
});
it('resolves nested groups', async () => {
config.extends = [':automergeLinters'];
Expand All @@ -159,7 +159,7 @@ describe('config/presets', () => {
const rule = res.packageRules[0];
expect(rule.automerge).toBe(true);
expect(rule.packageNames).toHaveLength(3);
expect(rule.packagePatterns).toHaveLength(3);
expect(rule.packagePatterns).toHaveLength(4);
});
it('migrates automerge in presets', async () => {
config.extends = ['ikatyang:library'];
Expand Down
2 changes: 1 addition & 1 deletion lib/config/presets/internal/packages.ts
Expand Up @@ -21,7 +21,7 @@ export const presets: Record<string, Preset> = {
eslint: {
description: 'All eslint packages',
packageNames: ['babel-eslint'],
packagePatterns: ['^eslint'],
packagePatterns: ['^@typescript-eslint/', '^eslint'],
},
stylelint: {
description: 'All stylelint packages',
Expand Down

0 comments on commit ed13e22

Please sign in to comment.