fix(git-submodules): sequential submodules processing (#11659) (#11661)

renovatebot · Sep 9, 2021 · f4ebbb7 · f4ebbb7
1 parent 955942b
commit f4ebbb7
Showing 1 changed file with 27 additions and 34 deletions.
diff --git a/lib/manager/git-submodules/extract.ts b/lib/manager/git-submodules/extract.ts
@@ -98,40 +98,33 @@ export default async function extractPackageFile(
     return null;
   }
 
-  const deps = (
-    await Promise.all(
-      depNames.map(async ({ name, path }) => {
-        try {
-          const [currentDigest] = (await git.subModule(['status', path]))
-            .trim()
-            .replace(/^[-+]/, '')
-            .split(/\s/);
-          const subModuleUrl = await getUrl(git, gitModulesPath, name);
-          // hostRules only understands HTTP URLs
-          // Find HTTP URL, then apply token
-          let httpSubModuleUrl = getHttpUrl(subModuleUrl);
-          httpSubModuleUrl = getRemoteUrlWithToken(httpSubModuleUrl);
-          const currentValue = await getBranch(
-            gitModulesPath,
-            name,
-            httpSubModuleUrl
-          );
-          return {
-            depName: path,
-            lookupName: getHttpUrl(subModuleUrl),
-            currentValue,
-            currentDigest,
-          };
-        } catch (err) /* istanbul ignore next */ {
-          logger.warn(
-            { err },
-            'Error mapping git submodules during extraction'
-          );
-          return null;
-        }
-      })
-    )
-  ).filter(Boolean);
+  const deps = [];
+  for (const { name, path } of depNames) {
+    try {
+      const [currentDigest] = (await git.subModule(['status', path]))
+        .trim()
+        .replace(/^[-+]/, '')
+        .split(/\s/);
+      const subModuleUrl = await getUrl(git, gitModulesPath, name);
+      // hostRules only understands HTTP URLs
+      // Find HTTP URL, then apply token
+      let httpSubModuleUrl = getHttpUrl(subModuleUrl);
+      httpSubModuleUrl = getRemoteUrlWithToken(httpSubModuleUrl);
+      const currentValue = await getBranch(
+        gitModulesPath,
+        name,
+        httpSubModuleUrl
+      );
+      deps.push({
+        depName: path,
+        lookupName: getHttpUrl(subModuleUrl),
+        currentValue,
+        currentDigest,
+      });
+    } catch (err) /* istanbul ignore next */ {
+      logger.warn({ err }, 'Error mapping git submodules during extraction');
+    }
+  }
 
   return { deps, datasource: datasourceGitRefs.id };
 }