rollbackPrs: Excluded versions should behave the same as missing versions #14379
Replies: 5 comments 4 replies
-
Hi there, Help us by making a minimal reproduction repository. Before we can start work on your issue we first need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. To get started, please read our guide on creating a minimal reproduction to understand what is needed. We may close the issue if you (or someone else) have not provided a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment. Good luck, The Renovate team |
Beta Was this translation helpful? Give feedback.
-
I created a public reproduction repository, reran Renovate against it and provided the debug log from that run. |
Beta Was this translation helpful? Give feedback.
-
Thanks. Please tell me if I understand the reproduction right below. Ideally this would be good to add a reproduction readme in future:
If so, then this wasn't our original intention, and our documentation doesn't leave any vagueness about it:
Therefore we will convert it to a discussion and can decide whether accepting this as a feature request makes sense. |
Beta Was this translation helpful? Give feedback.
-
@rarkins Your understanding is correct. Your conclusion makes sense. Can we convert this into a feature request? |
Beta Was this translation helpful? Give feedback.
-
I took a look and this and it's going to take some refactoring of our core lookup filtering and update logic - it's definitely not a quick/simple fix. If you have the time to work on it and can come up with an elegant solution then we'd accept it, but otherwise I think it needs to remain as a feature we don't support. e.g. would you still want to roll back even if there is a way to "roll forward"? |
Beta Was this translation helpful? Give feedback.
-
How are you running Renovate?
Self-hosted
If you're self-hosting Renovate, tell us what version of Renovate you run.
31.89.5
Please select which platform you are using if self-hosting.
GitLab self-hosted
If you're self-hosting Renovate, tell us what version of the platform you run.
14.8.0
Was this something which used to work for you, and then stopped?
I never saw this working
Describe the bug
When I use allowedVersions to limit which versions I want Renovate to update to, it should also rollback those versions to the latest allowed version, if rollbackPrs is enabled. This is required if an erroneous update has already been merged and I want to undo it.
Relevant debug logs
Logs
Have you created a minimal reproduction repository?
https://github.com/babiel/renovate-earthly-version-repro
Beta Was this translation helpful? Give feedback.
All reactions