PR's description is not updated with current state of updated packages

[anopheles]

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us what version of Renovate you run.

32.5.0

Please select which platform you are using if self-hosting.

github.com

If you're self-hosting Renovate, tell us what version of the platform you run.

latest

Was this something which used to work for you, and then stopped?

I never saw this working

Describe the bug

When a new dependency is found which can be integrated into an existing PR, the branch is correctly updated but the description of said PR still shows the old state.

I suspect that the renovate somehow can't access the list of PRs anymore and silently fails. As it can't find the PR it tries to create a new one and fails with the message

2022-04-09T00:12:26.8026062Z              "message": "Validation Failed",
2022-04-09T00:12:26.8026539Z              "errors": [
2022-04-09T00:12:26.8026957Z                {
2022-04-09T00:12:26.8027401Z                  "resource": "PullRequest",
2022-04-09T00:12:26.8027886Z                  "code": "custom",
2022-04-09T00:12:26.8028713Z                  "message": "A pull request already exists for repo:renovate/fulfill-major-fulfill."
2022-04-09T00:12:26.8029358Z                }
2022-04-09T00:12:26.8029763Z              ],
2022-04-09T00:12:26.8030538Z              "documentation_url": "https://docs.github.com/rest/reference/pulls#create-a-pull-request"
2022-04-09T00:12:26.8031172Z            },

I took a look at the code and could find this in the logs

2022-04-09T00:07:13.5141824Z DEBUG: Retrieving PR list (repository=repo, branch=renovate/XXX)
2022-04-09T00:07:18.1898175Z DEBUG: Retrieved 0 Pull Requests (repository=repo, branch=renovate/XXX)

Looks like the API is not giving me any PRs.

It worked before switching to a Github App (the PAT version worked before).

I'm further looking at the code

    config.prList = prList
      .filter(
        (pr) =>
          config.forkMode ||
          config.ignorePrAuthor ||
          (pr?.user?.login && config?.renovateUsername
            ? pr.user.login === config.renovateUsername
            : true)
      )

might be the culprit. I will investigate.

Relevant debug logs

Logs

2022-04-09T00:12:24.3496420Z DEBUG: mergeStatus=no automerge (repository=repo, branch=renovate/fulfill-major-fulfill)
2022-04-09T00:12:24.3528921Z DEBUG: Ensuring PR (repository=repo, branch=renovate/fulfill-major-fulfill)
2022-04-09T00:12:24.3535346Z DEBUG: There are 0 errors and 0 warnings (repository=repo branch=renovate/fulfill-major-fulfill)
2022-04-09T00:12:24.3562128Z DEBUG: getBranchPr(renovate/fulfill-major-fulfill) (repository=repo, branch=renovate/fulfill-major-fulfill)
2022-04-09T00:12:24.3568818Z DEBUG: findPr(renovate/fulfill-major-fulfill, undefined, open) (repository=repo, branch=renovate/fulfill-major-fulfill)
2022-04-09T00:12:24.3620270Z DEBUG: findPr(renovate/fulfill-major-fulfill, undefined, closed) (repository=repo, branch=renovate/fulfill-major-fulfill)
2022-04-09T00:12:24.3630588Z DEBUG: Removing duplicate release notes (repository=repo, branch=renovate/fulfill-major-fulfill)
2022-04-09T00:12:24.3631413Z "depName": "react-dom"
2022-04-09T00:12:26.3311542Z DEBUG: Creating PR (repository=repo, branch=renovate/fulfill-major-fulfill)

Have you created a minimal reproduction repository?

No reproduction repository

[rarkins]

It's most likely because you have not set "username" correctly to match your app name. Please read the docs for now to run as an app as it's described there. It should end in [bot]

[anopheles]

@rarkins thanks that was it!

Can this case (misconfiguration of the git author) be detected somehow? I would not expect my PRs not to be updated. I would expect some kind of warning in the logs.

[rarkins]

GitHub doesn't support a "whoami" for app installation tokens, as far as I'm aware. So that's why you need to tell the bot who it is by specifying username, for this specific case of using app tokens. It's in the docs, but many people overlook it. There might be a way to at least detect there's a problem, but I'm not sure of which way.