Create draft PRs on artifact update failure #15121
colinodell
started this conversation in
Suggest an Idea
Replies: 1 comment 2 replies
-
There should always be a renovate/artifacts failed status check in such cases. Are you seeing that, and your users are ignoring both the comment as well as the failing status check? |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Sometimes Renovate will fail to update an artifact (like a lock file) due to dependency conflicts:
A PR is still opened to inform the user (which is great) but that PR itself is mergeable (not so great). And if the CI pipeline isn't validating that all artifacts are present and in-sync it's very easy for a user to not understand the problem and merge the PR anyway. (This has happened numerous times on several repositories I co-mantain.)
Merging a "bad" PR is particularly problematic with Composer:
composer install
commands will still install dependencies without issue, but attempts to manually add, remove, or updates dependencies will fail with no easy resolution (besides finding the offending merge commits and reverting them).I therefore propose that any PRs with artifact update problems be moved into a
Draft
state if the platform supports it, and moved out ofDraft
if/when the issue is resolved. This could either be a default behavior or configurable with an option like"draftPROnFailure": true
.Doing this will add an extra safeguard for users who miss the
You probably do not want to merge this PR as-is
message and want to avoid getting bitten by this.Beta Was this translation helpful? Give feedback.
All reactions