Force creating Rate Limited PRs should not respect the PR limit

[StefanLobbenmeierObjego]

How are you running Renovate?

Mend Renovate hosted app on github.com

If you're self-hosting Renovate, tell us what version of Renovate you run.

No response

If you're self-hosting Renovate, select which platform you are using.

None

Was this something which used to work for you, and then stopped?

No, has not worked yet

Wanted end result.

When I go to the dependency dashboard and I select all rate limited PRs and click on force create:

It should no longer respect the pr per hour limit. I explicitly told the system to create all PRs, so the rules for automatic creation should no longer apply.

What you tried so far.

Tried via the button several times, it always only created 2 PRs.

I am aware that I could change the setting to allow more PRs per hour, but actually I like the setting in general, but when creating them manually I want to be able to override them.

Relevant debug logs

Full logs available in gist: https://gist.github.com/StefanLobbenmeierObjego/36aa65a8248b6f01fc5fa420d65c9f8a

Any logs that seem relevant for one of the branches that was not created: renovate/version.maven-plugin.project-info-report

Logs

DEBUG: Found PR #9
DEBUG: getBranchPr(renovate/version.maven-plugin.project-info-report)
DEBUG: findPr(renovate/version.maven-plugin.project-info-report, undefined, open)
DEBUG: findPr(renovate/version.maven-plugin.project-info-report, undefined, closed)

DEBUG: syncBranchState() (branch="renovate/version.maven-plugin.project-info-report")
DEBUG: getBranchPr(renovate/version.maven-plugin.project-info-report) (branch="renovate/version.maven-plugin.project-info-report")
DEBUG: findPr(renovate/version.maven-plugin.project-info-report, undefined, open) (branch="renovate/version.maven-plugin.project-info-report")
DEBUG: findPr(renovate/version.maven-plugin.project-info-report, undefined, closed) (branch="renovate/version.maven-plugin.project-info-report")
DEBUG: branchExists=false (branch="renovate/version.maven-plugin.project-info-report")
DEBUG: dependencyDashboardCheck=undefined (branch="renovate/version.maven-plugin.project-info-report")
DEBUG: Check for closed PR because recreating closed PRs is disabled. (branch="renovate/version.maven-plugin.project-info-report")
DEBUG: findPr(renovate/version.maven-plugin.project-info-report, REN-000 - Update dependency org.apache.maven.plugins:maven-project-info-reports-plugin to v3.4.5, !open) (branch="renovate/version.maven-plugin.project-info-report")
DEBUG: prAlreadyExisted=false (branch="renovate/version.maven-plugin.project-info-report")
DEBUG: Reached branch limit - skipping branch creation (branch="renovate/version.maven-plugin.project-info-report")

DEBUG: Branch summary
{
	...
  "inactiveBranches": [
    "renovate/version.maven-plugin.project-info-report",
	...
  ]
}

DEBUG: branches info extended
{
  "branchesInformation": [
	...
    {
      "branchName": "renovate/version.maven-plugin.project-info-report",
      "prNo": null,
      "prTitle": "REN-000 - Update dependency org.apache.maven.plugins:maven-project-info-reports-plugin to v3.4.5",
      "result": "branch-limit-reached",
      "upgrades": [
        {
          "datasource": "maven",
          "depName": "org.apache.maven.plugins:maven-project-info-reports-plugin",
          "displayPending": "",
          "fixedVersion": "3.4.2",
          "currentVersion": "3.4.2",
          "currentValue": "3.4.2",
          "newValue": "3.4.5",
          "newVersion": "3.4.5",
          "packageFile": "pom.xml",
          "updateType": "patch",
          "packageName": "org.apache.maven.plugins:maven-project-info-reports-plugin"
        }
      ]
    },
	...
  ]
}

[HonkingGoose]

I think that when you force a update, you basically add those updates to a PR-queue, which Renovate then opens one-at-a-time. I think Renovate always respects the prHourlyLimit, which defaults to 2.

Or it may be caused by limitations of the Mend hosted app.

[StefanLobbenmeierObjego]

yeah I think this is what is happening

DEBUG: Reached branch limit - skipping branch creation (branch="renovate/version.maven-plugin.project-info-report")

I feel then the wording and UX is way off what the feature is actually doing though.

[StefanLobbenmeierObjego]

Could it be that it is completely disregarding the selected branches and just triggers a normal workflow?

[github-actions[bot]]

Hi there,

This issue or discussion is missing some logs, making it difficult or impossible to help you. Depending on which situation applies follow one, some or all of these instructions.

No logs at all

If you haven't posted any log yet, we need you to find and copy/paste the log into the issue template.

Finding logs on hosted app

Select me to read instructions

If you use the Renovate app (GitHub):

1. Go to the affected PR, and search for "View repository job log here"
2. Select the link to go to the "Mend Renovate Dashboard" and log in
3. You are now in the correct repository log overview screen
4. Copy/paste the correct log
5. Follow the steps in the formatting your logs section

Finding logs when self-hosting

Select me to read instructions

If you're running self-hosted, run with LOG_LEVEL=debug in your environment variables and search for whatever dependency/branch/PR that is causing the problem.

Insufficient logs

Select me to read instructions

If you already gave us a log, and the Renovate team said it's not enough, then follow the instructions from the No logs at all section.

Formatting your logs

Select me to read instructions

Please put your logs in a <details> and <summary> element like this:

<details><summary>Select me to see logs</summary>

```
Copy/paste your logs here, between the starting and ending backticks
```

</details>

Good luck,

The Renovate team

[rarkins]

Please narrow the logs to just the logs for the one branch you wish to use as an example

[StefanLobbenmeierObjego]

I now cut down to the part where it says branch-limit-reached and put the rest of the logs in a gist for reference

[rarkins]

Please, everything with branch= the branch you want me to look at.

[StefanLobbenmeierObjego]

I now did a search for "renovate/version.maven-plugin.project-info-report", which is one of the branches where the branch limit was reached and put in every log message that had it in message, is that what you want?

[rarkins]

From the config passed to Renovate you can see:

    "checkedBranches": [
      "renovate/version.maven-plugin.project-info-report",
      "renovate/version.maven-plugin.resource",
      "renovate/version.maven-plugin.site",
      "renovate/version.maven-plugin.jacoco",
      "renovate/version.lombok",
      "renovate/version.slf4j.api",
      "renovate/spring-boot",
      "renovate/spring-core",
      "renovate/version.commons.lang",
      "renovate/version.maven-plugin.clean",
      "renovate/version.maven.compiler",
      "renovate/version.maven-plugin.deploy",
      "renovate/version.maven-plugin.surefire",
      "renovate/version.sonarqube",
      "renovate/junit5-monorepo",
      "renovate/mockito-monorepo"
    ],

So that branch was included. It would seem that this line is reached without checkedBranches being considered:

DEBUG: Reached branch limit - skipping branch creation (branch="renovate/version.maven-plugin.project-info-report")