Missing changelog for GitHub/Maven dependency

[rombert]

How are you running Renovate?

Mend Renovate hosted app on github.com

If you're self-hosting Renovate, tell us what version of Renovate you run.

No response

If you're self-hosting Renovate, select which platform you are using.

None

Was this something which used to work for you, and then stopped?

I never saw this working

Wanted end result.

PR rombert/pospai#149 brought in a change for https://github.com/apache/sling-slingfeature-maven-plugin . There was no changelog attached, even though the sourceUrl was detected properly.

What you tried so far.

I hoped this would work without any changes :-)

Relevant debug logs

Logs

{
            "currentValue": "1.7.2",
            "currentVersion": "1.7.2",
            "datasource": "maven",
            "depName": "org.apache.sling:slingfeature-maven-plugin",
            "depType": "build",
            "fileReplacePosition": 2697,
            "fixedVersion": "1.7.2",
            "groupName": "slingfeature.plugin.version",
            "homepage": "https://sling.apache.org/components/slingfeature-maven-plugin/",
            "packageName": "org.apache.sling:slingfeature-maven-plugin",
            "registryUrl": "https://repo.maven.apache.org/maven2",
            "registryUrls": [
              "https://repo.maven.apache.org/maven2"
            ],
            "sourceUrl": "https://github.com/apache/sling-slingfeature-maven-plugin",
            "versioning": "maven",
            "warnings": [],
            "updates": [
              {
                "bucket": "non-major",
                "newVersion": "1.7.4",
                "newValue": "1.7.4",
                "releaseTimestamp": "2023-11-04T14:35:50.000Z",
                "newMajor": 1,
                "newMinor": 7,
                "updateType": "patch",
                "branchName": "renovate/slingfeature.plugin.version"
              }
            ],
            "isSingleVersion": true
          }

[HonkingGoose]

Does that upstream package set the scm section of their pom.xml file correctly? Read the Renovate docs, making your maven changelogs fetchable to learn more.

[rombert]

I see that the pom.xml for the new 1.7.4 version has the correct version - https://github.com/apache/sling-slingfeature-maven-plugin/blob/slingfeature-maven-plugin-1.7.4/pom.xml#L46 but the old 1.7.2 does not - https://github.com/apache/sling-slingfeature-maven-plugin/blob/slingfeature-maven-plugin-1.7.2/pom.xml#L45 . Does Renovate check both?

[rarkins]

Which release notes are you expecting? The repo doesn't have releases: https://github.com/apache/sling-slingfeature-maven-plugin/releases

[rombert]

Ah, that is a shame.

I know many Maven projects that don't generate GitHub release ( at least at the Apache Software foundation) and create plain Git tags instead.

When looking at a Renovate PR that provides a changelog I see a 'Compare source' link.

Is generating such a 'Compare source' link based on GitHub tags only in scope for renovate? It can be easily computed from the new and old pom.xml, assuming that they have the same SCM URL and point to GitHub.

[rarkins]

Assuming that the source repo is known, it should be possible to set up a "compare source" link. Please create a minimal reproduction repo if you'd like us to look into it (instructions below)

[rombert]

Sure, here is the repository - https://github.com/rombert/renovate-maven-tag-changelog .
There is one PR created - rombert/renovate-maven-tag-changelog#4. This PR updates a Maven plugin from version 1.7.4 to 1.8.0 . The scm sections from the old and new versions are https://github.com/apache/sling-slingfeature-maven-plugin/blob/slingfeature-maven-plugin-1.7.4/pom.xml#L43-L47 and https://github.com/apache/sling-slingfeature-maven-plugin/blob/slingfeature-maven-plugin-1.8.0/pom.xml#L43-L47 .

Hope that covers the minimal reproduction.

[rarkins]

This one would be particularly challenging considering they don't use "clean" git tags and instead prefix it: https://github.com/apache/sling-slingfeature-maven-plugin/tags

[rombert]

Yes, this is the default maven-release-plugin behaviour - https://maven.apache.org/maven-release/maven-release-plugin/prepare-mojo.html#tagNameFormat .

[github-actions[bot]]

Hi there,

Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction.

We may close the discussion if you, or someone else, haven't created a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team